Skip to content

Commit 26805f9

Browse files
authored
closes #2327 - Word labels incorrectly removed when editing emoji (#2352)
2 parents 2c1848f + 6077865 commit 26805f9

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

src/main/java/ai/elimu/web/content/emoji/EmojiEditController.java

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,19 +92,24 @@ public String handleSubmit(
9292

9393
return "content/emoji/edit";
9494
} else {
95-
emoji.setRevisionNumber(emoji.getRevisionNumber() + 1);
96-
emojiDao.update(emoji);
95+
Emoji persistentEmoji = emojiDao.read(emoji.getId());
96+
persistentEmoji.setGlyph(emoji.getGlyph());
97+
persistentEmoji.setUnicodeVersion(emoji.getUnicodeVersion());
98+
persistentEmoji.setUnicodeEmojiVersion(emoji.getUnicodeEmojiVersion());
99+
persistentEmoji.setRevisionNumber(persistentEmoji.getRevisionNumber() + 1);
100+
101+
emojiDao.update(persistentEmoji);
97102

98103
EmojiContributionEvent emojiContributionEvent = new EmojiContributionEvent();
99104
emojiContributionEvent.setContributor((Contributor) session.getAttribute("contributor"));
100105
emojiContributionEvent.setTimestamp(Calendar.getInstance());
101-
emojiContributionEvent.setEmoji(emoji);
102-
emojiContributionEvent.setRevisionNumber(emoji.getRevisionNumber());
106+
emojiContributionEvent.setEmoji(persistentEmoji);
107+
emojiContributionEvent.setRevisionNumber(persistentEmoji.getRevisionNumber());
103108
emojiContributionEventDao.create(emojiContributionEvent);
104109

105-
DiscordHelper.postToChannel(Channel.CONTENT, "Emoji " + emoji.getGlyph() + " updated: " + DomainHelper.getBaseUrl() + "/content/emoji/edit/" + emoji.getId());
110+
DiscordHelper.postToChannel(Channel.CONTENT, "Emoji " + persistentEmoji.getGlyph() + " updated: " + DomainHelper.getBaseUrl() + "/content/emoji/edit/" + persistentEmoji.getId());
106111

107-
return "redirect:/content/emoji/list#" + emoji.getId();
112+
return "redirect:/content/emoji/list#" + persistentEmoji.getId();
108113
}
109114
}
110115

0 commit comments

Comments
 (0)