Merge branch 'master' into feature/clock_tree_extractor

Author: saschatommasone

.github/workflows/ubuntu24.04.yml

@@ -98,6 +98,14 @@ jobs:
         # Execute the build.  You can specify a specific target with "--target <NAME>"
         run: |
           cd build
+          echo "==> Disk usage before clean"
+          df -h .
+          sudo rm -rf /usr/share/dotnet
+          sudo rm -rf /opt/ghc
+          sudo rm -rf /usr/local/lib/android
+          sudo rm -rf /opt/hostedtoolcache
+          echo "==> Disk usage after clean"
+          df -h .
           ninja
         env:
           CCACHE_DIR: ${{runner.workspace}}/.ccache

CHANGELOG.md

@@ -2,6 +2,15 @@
 All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
+* added information to GUI setting file so that widgets position and size from previous session gets restored
+* added option to focus on pin in pin context menu
+* plugins
+  * fixed bug in waveform viewer, make sure that deleting a controller causes closing the tab
+  * fixed broken initialization of DANA plugin when starting via CLI
+  * changed behavior of GUI plugin manager to keep only those plugins loaded which are requested by user
+  * fixed bug in the bitorder propagation algorithm that would assign a wrong propagation order if pingroups with direction none were given as parameters
+
+## [4.5.0](v4.5.0) - 2025-09-23 12:00:00+02:00 (urgency: medium)
 * plugins
   * simulation
     * added simulation engine property `timeout_after_sec`
@@ -22,7 +31,6 @@ All notable changes to this project will be documented in this file.
     * updated the hgl format version for the provided `.hgl` libraries and added the `ordered` attribute to all pin groups, which defaults to false
   * added scrollbar in `logic evaluator` plugin
   * added `dataflow::Result::create_modules` function that takes nothing but group IDs for easier module creation
-  * fixed a bug in the bitorder propagation algorithm that would assign a wrong propagation order if pingroups with direction none were given as parameters
   * added feature to import precompiled binary plugins in GUI plugin manager
   * added switch to GUI plugin manager to activate/deactivate menu contribution for plugin
 * build process

include/hal_core/netlist/boolean_function/parser.h

@@ -38,6 +38,8 @@ namespace hal
             Liberty,
             /// refers to the 'Standard' Boolean function parser
             Standard,
+            /// as 'Liberty' above, but removing space first
+            LibertyNoSpace
         };
 
         /// TokenType refers to a token identifier for a Boolean function string.

plugins/dataflow_analysis/src/api/result.cpp

@@ -283,7 +283,7 @@ namespace hal
                 write_path /= "graph.dot";
             }
 
-            if (write_path.extension() != "dot")
+            if (write_path.extension() != ".dot")
             {
                 log_info("dataflow", "replacing invalid file extension '{}' with '.dot' ...", write_path.extension().string());
                 write_path.replace_extension("dot");
@@ -357,7 +357,7 @@ namespace hal
                 write_path /= "groups.txt";
             }
 
-            if (write_path.extension() != "txt")
+            if (write_path.extension() != ".txt")
             {
                 log_info("dataflow", "replacing invalid file extension '{}' with '.txt' ...", write_path.extension().string());
                 write_path.replace_extension("txt");

plugins/dataflow_analysis/src/plugin_dataflow.cpp

@@ -62,6 +62,9 @@ namespace hal
         UNUSED(args);
 
         dataflow::Configuration config(nl);
+        config.with_control_pin_types({PinType::clock, PinType::enable, PinType::reset, PinType::set});
+        config.with_gate_types({GateTypeProperty::ff});
+
         std::string path;
 
         if (args.is_option_set("--path"))
@@ -103,6 +106,19 @@ namespace hal
             return false;
         }
 
+        if (!path.empty())
+        {
+            auto grouping = grouping_res.get();
+            if (const auto res = grouping.write_dot(path); res.is_error())
+            {
+                log_error("dataflow", "could not write .dot file:\n{}", res.get_error().get());
+            }
+            if (const auto res = grouping.write_txt(path); res.is_error())
+            {
+                log_error("dataflow", "could not write .txt file:\n{}", res.get_error().get());
+            }
+        }
+
         return true;
     }
 

plugins/dot_viewer/deps/QGVCore/QGVScene.cpp

@@ -81,6 +81,8 @@ QGVScene::QGVScene(QObject *parent)
 
 QGVScene::~QGVScene()
 {
+    for (QGraphicsItem* item : items())
+        item->setSelected(false);
     gvFreeLayout(_context->context(), _graph->graph());
     agclose(_graph->graph());
     gvFreeContext(_context->context());

plugins/dot_viewer/include/dot_viewer/dot_graphics_view.h

@@ -28,6 +28,7 @@
 
 #include <QGraphicsView>
 #include <QWheelEvent>
+#include <QMouseEvent>
 
 namespace hal
 {
@@ -42,9 +43,14 @@ namespace hal
         void handleZoomOutShortcut();
 
     protected:
-        virtual void wheelEvent(QWheelEvent* event);
+        void wheelEvent(QWheelEvent* event) override;
+        void mousePressEvent(QMouseEvent* event) override;
+        void mouseMoveEvent(QMouseEvent* event) override;
 
     private:
+        QPoint mMovePosition;
+        Qt::KeyboardModifier mPanModifier;
+
         void scaleWithinLimits(qreal scaleFactor);
     };
 }

plugins/dot_viewer/include/dot_viewer/dot_viewer.h

@@ -59,6 +59,7 @@ namespace hal
         static DotViewer* getDotviewerInstance();
         QString filename() const { return mFilename; }
         QString creatorPlugin() const { return mCreatorPlugin; }
+        bool loadDotFile(const QString& fileName, const QString& creator = QString());
 
     public Q_SLOTS:
         void handleOpenInputFileByName(const QString& fileName, const QString& creator = QString());
@@ -84,7 +85,7 @@ namespace hal
         Q_OBJECT
     public:
         DotViewerCallFromTread(QObject* parent = nullptr) : QObject(parent) {;}
-        void emitOpenInputFileByName(DotViewer* callee, QString filename, QString plugin);
+        bool openInputFileByName(DotViewer* callee, QString filename, QString plugin);
     Q_SIGNALS:
         void callOpenInputFileByName(QString filename, QString plugin);
     };

plugins/dot_viewer/include/dot_viewer/interaction/dataflow_interaction.h

@@ -31,6 +31,8 @@
 #include <QHash>
 
 namespace hal {
+    class Module;
+
     class DataflowInteraction : public QGVInteraction {
         Q_OBJECT
     public:
@@ -41,6 +43,7 @@ namespace hal {
 
     private Q_SLOTS:
         void handleHALSelectionChanged(void* sender);
+        void handleHALModuleNameChanged(Module* m);
         void handleQGVSelectionChanged();
         void handleEdgeContextMenu(QGVEdge* edge);
 

plugins/dot_viewer/include/dot_viewer/interaction/solve_fsm_interaction.h

@@ -37,6 +37,7 @@ namespace hal {
         Q_OBJECT
     public:
         SolveFsmInteraction(QGVScene* parent);
+        ~SolveFsmInteraction();
 
         void registerNode(QGVNode* node) override;
         void registerEdge(QGVEdge* edge) override;