-
Notifications
You must be signed in to change notification settings - Fork 7
Update home & build #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This doesn't not work currently on many fronts.
|
|
The current setup fails, if you call EOD - need to come back on another day. |
|
I pushed a patch which fixes a part of that issue by simply removing the fftlog/ dir, just doing src/ directly. |
|
With these patches I see the same test failure in the CI job as I do locally. I figure you're more familiar with the API and can work on that for a bit. |
|
Thanks, much appreciated! That is also the one I had locally. If I remember right, |
|
The current error is Something must have changed in |
To work with python >= 3.12, which will deprecated numpy.distutils, port
the build to meson and pyproject.
$ pip install build
$ python -m build
$ cd test && python -c "import fftlog; print(fftlog.__all__)"
['fhti', 'fftl', 'fht', 'fhtq']
The cd test is to avoid trying to import from $(pwd)/fftlog.
This just changes the build, and does not hard constrain versions.
Follow up work should be to figure out true minimum versions, maybe test
with different compilers, and fix the type error in ifac and friends.
The directory tree is flattened because fftlog/ doesn't form a cohesive
module as-is. Due to the presence of the __init__.py the dir would be
detected as a module and loaded by pytest and friends, shadowing the
installed one and failing because it does not find the native extension.
Finally, remove __init__.py from tests/ to not pretend it is a module
anymore.
Update repo for:
prisaeto theemsig-org;distutilstomeson(thanks @jokva).