Modifier Behavior on Key Release Inconsistent

[AustinMReppert]

When releasing a modifier key like control, the modifiers reported are different.

windows:
Keyboard event: KeyboardEvent { state: Up, key: Named(Control), code: ControlLeft, location: Left, modifiers: Modifiers(0x0), repeat: false, is_composing: false }

web:
Keyboard event: KeyboardEvent { state: Up, key: Named(Control), code: ControlLeft, location: Left, modifiers: Modifiers(CONTROL), repeat: false, is_composing: false }

[waywardmonkeys]

Did you get the web one from winit? or via your own code using web_sys or other?

[xorgy]

When you say ‘I believe the web results are the intended behavior’ are you saying that we might replicate this behavior because it is normal in browsers, or because you'd actually prefer it? Because if I was asked which I prefer, the Windows sample above would 100% be my preference, and I think it would be yours from what I can see:

craft-gui/craft@2605940#diff-92549685a66b243ed86d7ef1850896c974111d921d8cbfbaca4079e8322bc0e6R449-R451

It seems really unhelpful to report modifiers unchanged after they are released.

[AustinMReppert]

Here is a simple example:
https://github.com/AustinMReppert/ui-events/tree/example

Firefox Vs Chrome

Windows:

I think the windows behavior makes sense and is also how browsers behave, if I recall correctly.

[xorgy]

Ah, could this be an issue caused by the sequencing of WindowEvent::ModifiersChanged relative to WindowEvent::KeyboardInput? We might need to process keyup events for modifier keys directly as a special case in ui-events-winit. (or maybe it's a winit bug)

[waywardmonkeys]

Or just fix the bug in winit.