issue with numpy 2.0

[tynanford]

We noticed our CI builds stopped working about a week ago and it was narrowed down to pyDevSup compilation failing.

../dbfield.c: In function 'build_array':
../dbfield.c:101:13: error: 'PyArray_Descr' {aka 'struct _PyArray_Descr'} has no member named 'elsize'
  101 |         desc->elsize = MAX_STRING_SIZE;
      |             ^~
../dbfield.c: In function 'assign_array':

Confirmed it is due to the numpy version. 2.0.0 which was released on June 16th - https://pypi.org/project/numpy/#history

And this release note seems relevant https://numpy.org/devdocs/release/2.0.0-notes.html#descriptor-elsize-and-alignment-access . Pinning numpy down to 1.26.4 works for now

[mdavidsaver]

... the elsize and aligment fields must now be accessed via PyDataType_ELSIZE, PyDataType_SET_ELSIZE ...

I guess PyDataType_SET_ELSIZE() is added with numpy 2?

[tynanford]

Yes that's right. This change at least makes it compile with numpy 1.x and 2.x

diff --git a/devsupApp/src/dbfield.c b/devsupApp/src/dbfield.c
index 4a03cba..25caa00 100644
--- a/devsupApp/src/dbfield.c
+++ b/devsupApp/src/dbfield.c
@@ -40,6 +40,10 @@ static const int dbf2np_map[DBF_MENU+1] = {
     NPY_INT16,   // DBF_MENU
 };
 static PyArray_Descr* dbf2np[DBF_MENU+1];
+#if NPY_ABI_VERSION < 0x02000000
+  #define PyDataType_ELSIZE(descr) ((descr)->elsize)
+  #define PyDataType_SET_ELSIZE(descr, size) (descr)->elsize = size
+#endif
 #endif
 
 typedef struct {
@@ -98,7 +102,8 @@ static PyObject* build_array(PyObject* obj, void *data, unsigned short ftype, un
 
     desc = dbf2np[ftype];
     if(ftype==DBF_STRING) {
-        desc->elsize = MAX_STRING_SIZE;
+        PyDataType_SET_ELSIZE(desc, MAX_STRING_SIZE);
+        //desc->elsize = MAX_STRING_SIZE;
     }
 
     Py_XINCREF(desc);