Fix: Refactoring and Stop spawn.

No longer `eslint-cli` does not spawn a child process to run a local
ESLint.
It runs that in own process merely.

Author: mysticatea

bin/eslint-cli.js

@@ -12,100 +12,24 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-var spawn = require("child_process").spawn;
-var fs = require("fs");
 var path = require("path");
-var chalk = require("chalk");
 var debug = require("debug")("eslint-cli");
 var resolve = require("resolve").sync;
 
-var cwd = process.cwd();
-
 //------------------------------------------------------------------------------
 // Helpers
 //------------------------------------------------------------------------------
 
-/**
- * Checks whether or not the file which is at given path exists.
- *
- * @param {string} filePath - A file path to check.
- * @returns {boolean} `true` if the file which is at given path exists.
- */
-function exists(filePath) {
-    try {
-        return fs.statSync(filePath).isFile();
-    }
-    catch (err) {
-        return false;
-    }
-}
-
-/**
- * Executes a given JavaScript file with the same arguments as this.
- *
- * @param {string} filePath - A file path to execute.
- * @returns {child_process.ChildProcess|null} A child process or null.
- */
-function execute(filePath) {
-    var command = process.argv[0];
-    var args = process.argv.slice(1);
-    args[0] = filePath;
-
-    debug("EXECUTE", command, args);
-
-    try {
-        return spawn(command, args, {stdio: "inherit"});
-    }
-    catch (err) {
-        debug("FAILED TO EXECUTE", err.stack);
-        return null;
-    }
-}
-
-/**
- * Finds and tries executing "./bin/eslint.js".
- *
- * This is useful to ESLint contributors.
- * ESLint's repository has "./bin/eslint.js".
- *
- * @returns {child_process.ChildProcess|null} A child process or null.
- */
-function tryExecutingBinEslintJs() {
-    var dir = cwd;
-    var prevDir = dir;
-    do {
-        var binPath = path.join(dir, "bin", "eslint.js");
-        if (exists(binPath)) {
-            debug("FOUND", binPath);
-            return execute(binPath);
-        }
-        debug("NOT FOUND", binPath);
-
-        // Finish if package.json is found.
-        if (exists(path.join(dir, "package.json"))) {
-            break;
-        }
-
-        // Go to next.
-        prevDir = dir;
-        dir = path.resolve(dir, "..");
-    }
-    while (dir !== prevDir);
-
-    debug("NOT FOUND", "\"./bin/eslint.js\"");
-    return null;
-}
-
 /**
  * Finds and tries executing a local eslint module.
  *
- * @returns {child_process.ChildProcess|null} A child process or null.
+ * @param {string} basedir - A path of the directory that it starts searching.
+ * @returns {string|null} The path of a local eslint module.
  */
-function tryExecutingESLint() {
+function getLocalEslint(basedir) {
     var indexPath = null;
     try {
-        indexPath = resolve("eslint", {basedir: cwd});
-        debug("FOUND", indexPath);
+        indexPath = resolve("eslint", {basedir: basedir});
     }
     catch (err) {
         debug("NOT FOUND", "\"eslint\"");
@@ -114,33 +38,27 @@ function tryExecutingESLint() {
 
     var binPath = path.resolve(path.dirname(indexPath), "..", "bin", "eslint.js");
     debug("FOUND", binPath);
-    return execute(binPath);
+    return binPath;
 }
 
 //------------------------------------------------------------------------------
 // Main
 //------------------------------------------------------------------------------
 /* eslint-disable no-process, no-console */
 
+var cwd = process.cwd();
+
 debug("START", process.argv);
 debug("ROOT", cwd);
 
-var task = tryExecutingBinEslintJs() || tryExecutingESLint();
-
-if (task == null) {
-    console.error(chalk.red.bold(
+var binPath = getLocalEslint(cwd) || require("../lib/get-bin-eslint-js")(cwd);
+if (binPath != null) {
+    require(binPath);
+}
+else {
+    console.error(require("chalk").red.bold(
         "Cannot find local ESLint!\n" +
         "Please install ESLint by `npm install eslint --save-dev`.\n"
     ));
     process.exit(1);
 }
-
-debug("PID", task.pid);
-
-task.on("exit", function(exitCode) {
-    debug("EXIT", exitCode);
-    process.exit(exitCode);
-});
-task.on("error", function(error) {
-    debug("ERROR", error.stack);
-});

lib/get-bin-eslint-js.js

@@ -0,0 +1,73 @@
+/**
+ * @author Toru Nagashima
+ * @copyright 2015 Toru Nagashima. All rights reserved.
+ * See LICENSE file in root directory for full license.
+ */
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+var fs = require("fs");
+var path = require("path");
+var debug = require("debug")("eslint-cli");
+
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+/**
+ * Checks whether or not the file which is at given path exists.
+ *
+ * @param {string} filePath - A file path to check.
+ * @returns {boolean} `true` if the file which is at given path exists.
+ */
+function exists(filePath) {
+    try {
+        return fs.statSync(filePath).isFile();
+    }
+    catch (err) {
+        return false;
+    }
+}
+
+//------------------------------------------------------------------------------
+// Public Interface
+//------------------------------------------------------------------------------
+
+/**
+ * Finds and tries executing "./bin/eslint.js".
+ *
+ * This is useful to ESLint contributors.
+ * ESLint's repository has "./bin/eslint.js".
+ *
+ * @param {string} basedir - A path of the directory that it starts searching.
+ * @returns {string|null} The path of "./bin/eslint.js"
+ */
+module.exports = function getBinEslintJs(basedir) {
+    var dir = basedir;
+    var prevDir = dir;
+    do {
+        var binPath = path.join(dir, "bin", "eslint.js");
+        if (exists(binPath)) {
+            debug("FOUND", binPath);
+            return binPath;
+        }
+        debug("NOT FOUND", binPath);
+
+        // Finish if package.json is found.
+        if (exists(path.join(dir, "package.json"))) {
+            break;
+        }
+
+        // Go to next.
+        prevDir = dir;
+        dir = path.resolve(dir, "..");
+    }
+    while (dir !== prevDir);
+
+    debug("NOT FOUND", "\"./bin/eslint.js\"");
+    return null;
+};

package.json

@@ -1,10 +1,8 @@
 {
   "name": "eslint-cli",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "The local eslint executor.",
-  "files": [
-    "bin"
-  ],
+  "files": ["bin", "lib"],
   "bin": {
     "eslint": "bin/eslint-cli.js",
     "eslint-cli": "bin/eslint-cli.js"