-
Notifications
You must be signed in to change notification settings - Fork 10.2k
[2025-10-25] Manual Dependency Bump #20830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 22 files with indirect coverage changes @@ Coverage Diff @@
## main #20830 +/- ##
==========================================
+ Coverage 69.15% 69.32% +0.16%
==========================================
Files 422 422
Lines 34824 34824
==========================================
+ Hits 24084 24141 +57
+ Misses 9341 9296 -45
+ Partials 1399 1387 -12 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@joshjms, could you please run Thanks. |
|
I ran make fix before each commit :( when I run make fix again, nothing changes |
18102c4 to
4cb190b
Compare
|
Ah, @joshjms, I think an issue could be that the go module update runs before go mod tidy. I checked out |
|
I didn't see a |
4e96e6d to
146e816
Compare
|
@ivanvc Now go_workspace passes but the test still fails :( |
|
/retest |
146e816 to
e85b2ca
Compare
Signed-off-by: joshjms <[email protected]>
Signed-off-by: joshjms <[email protected]>
Signed-off-by: joshjms <[email protected]>
Signed-off-by: joshjms <[email protected]>
Signed-off-by: joshjms <[email protected]>
e85b2ca to
276097f
Compare
|
/retest |
ahrtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/retest |
ivanvc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @joshjms.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, joshjms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@joshjms: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.
Dependabot raised the following PRs:
Bumped
Fully indirect
/cc @ivanvc @ahrtr @henrybear327
P.S. Thanks @henrybear327 for the update_dep.sh :D