Skip to content

Conversation

@joshjms
Copy link
Member Author

joshjms commented Oct 21, 2025

/retest

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.32%. Comparing base (bd7796b) to head (276097f).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20830      +/-   ##
==========================================
+ Coverage   69.15%   69.32%   +0.16%     
==========================================
  Files         422      422              
  Lines       34824    34824              
==========================================
+ Hits        24084    24141      +57     
+ Misses       9341     9296      -45     
+ Partials     1399     1387      -12     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7796b...276097f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ivanvc
Copy link
Member

ivanvc commented Oct 21, 2025

@joshjms, could you please run make fix? And commit again? Ideally, we should be committing the go.work.sum with every go.sum update, not as a separate commit. But while we adjust to this, it's fine to do it this way.

Thanks.

@joshjms
Copy link
Member Author

joshjms commented Oct 21, 2025

I ran make fix before each commit :( when I run make fix again, nothing changes

@joshjms joshjms force-pushed the deps_mgmt_21_10_25 branch from 18102c4 to 4cb190b Compare October 21, 2025 17:54
@ivanvc
Copy link
Member

ivanvc commented Oct 21, 2025

Ah, @joshjms, I think an issue could be that the go module update runs before go mod tidy.

I checked out b3229b0, and then ran make fix, and there are changes to go.work.sum.

@joshjms
Copy link
Member Author

joshjms commented Oct 22, 2025

I didn't see a b3229b0 commit :(

@joshjms
Copy link
Member Author

joshjms commented Oct 22, 2025

@ivanvc Now go_workspace passes but the test still fails :(

@joshjms
Copy link
Member Author

joshjms commented Oct 22, 2025

/retest

@ivanvc
Copy link
Member

ivanvc commented Oct 22, 2025

@joshjms, please take a look at #20839. I did what I mentioned, checked out each individual commit, and ran make fix. The verify job passes. You can use it as a reference, or if you'd like, I can take over your pull request.

@joshjms joshjms force-pushed the deps_mgmt_21_10_25 branch from e85b2ca to 276097f Compare October 22, 2025 16:51
@joshjms
Copy link
Member Author

joshjms commented Oct 22, 2025

/retest

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & thx

cc @ivanvc @jmhbnz

@ivanvc
Copy link
Member

ivanvc commented Oct 22, 2025

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @joshjms.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@joshjms: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-coverage-report 276097f link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahrtr ahrtr merged commit 8cf4986 into etcd-io:main Oct 22, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants