core/vm: implement EIP-8024 #33095
Open
core/vm: implement EIP-8024 #33095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes there was an inconsistency between the spec and that test. I've updated the spec to match the execution test, please see ethereum/EIPs#10704. |
Contributor
|
We can merge this if you remove the Amsterdam fork stuff. Just keep it as an 'extra EIP' for now. |
Author
Roger that. I removed the fork wiring. I'll continue to monitor this PR in case there is anything else I need to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-8024: Backward compatible SWAPN, DUPN, EXCHANGE
Taking a stab at implementing this. There may be an issue with the EXCHANGE execution test defined in the spec. I’ve patched it for now and flagged it to @lightclient. I will update this PR if the spec changes.