What is the process for a sample submission?

[chrisk-7777]

Hello,

I was looking at #3153, and see we needed a Tetris example. I've taken a crack below, I still need a few nights of tidy up, but I was wondering what the process of adding these as Excalibur samples?

Especially from a code quality perspective. Are the particular aspects that should be focused on to be a sample, vs part of the showcase?

• 🕹️ Playable demo: https://chrisk-7777.github.io/excalitris/
• 💾 Codebase: https://github.com/chrisk-7777/excalitris/tree/main

There are still some bugs, especially on mobile. The transparent background for example doesn't work correctly on mobs.

[eonarheim]

@chrisk-7777 This is perfect! A discussion (like this) or PR discussion is perfect process for including it. As long as a maintainer is cool with it they can merge things in. Eventually I'd want to host this on an official excalibur gh org repo if you're cool with that (we can do a fork too)

As far as a code quality, I'd say anything roughly excalibur idiomatic (similar to other samples/docs) is good enough.

My distinction for a sample is we intend this to be a learning tool and/or a springboard to clone and run with, so the code is built in a way that promotes that learning/cloning goal.

Showcase I view as anything anyone makes that they want to show off that fits within our community rules as a way of signal boosting both ex and their project!

In any case, I support this sample game! I'll take a look at the code when I have a few free cycles in the next day or so

[chrisk-7777]

Awesome, thanks Erik. More than happy for it to sit under the gh org repo.

I'll do a little more tidy up in the next few days, so no huge rush from me, I just wanted to get the conversation started. I will do a scan against the other samples to make sure this one is mostly excalibur idiomatic.

In a few days I'll drop a comment to say its ready for review.

Cheers

[chrisk-7777]

Ok I think its ready for a look now 😅

I swapped over some bits and pieces so I am leaning more heavily into excaliburjs (e.g. I completely forgot about the built in rand pickOne method - super handy!)

Very very open to feedback though. My other excalibur games are more turn based and so don't rely on the core loop as heavily. So there are probably gaps in my knowledge and approach.

[eonarheim]

@chrisk-7777 Deleted the fork! Give it another try

[chrisk-7777]

Thanks @eonarheim

I still received the below error, so I transferred it directly to you, then I guess you can shuffle it into the excaliburjs org?

Just a heads up, the action file will probably need to come out. And I can raise a PR to update the samples page with links, etc (probably tomorrow evening)

[eonarheim]

Oh sure, the fork name might have been reserved for a while... arg I'll try renaming it or something

[chrisk-7777]

Cheers! 🙌

[eonarheim]

Victory! Must have needed a cool down https://github.com/excaliburjs/excalitris