fbandroid/libraries/fresco/imagepipeline/src/test/java/com/facebook/imagepipeline/producers/DecodeProducerTest.java

Reviewed By: nlutsenko

Differential Revision: D86083526

fbshipit-source-id: 7857cae308d7939b432a66846c63f7354010ed3b

Author: generatedunixname537391475639613

imagepipeline/src/test/java/com/facebook/imagepipeline/producers/DecodeProducerTest.java

@@ -7,7 +7,7 @@
 
 package com.facebook.imagepipeline.producers;
 
-import static org.junit.Assert.*;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.*;
 import static org.mockito.Mockito.mockConstruction;
 import static org.mockito.Mockito.mockStatic;
@@ -255,9 +255,8 @@ public void testNewResult_Intermediate_pJPEG() {
     inOrder.verify(mJobScheduler).updateJob(mEncodedImage, Consumer.NO_FLAGS);
     inOrder.verify(mProgressiveJpegParser).parseMoreData(argumentCaptor.capture());
     inOrder.verify(mJobScheduler).scheduleJob();
-    assertSame(
-        ((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly(),
-        mByteBufferRef.getUnderlyingReferenceTestOnly());
+    assertThat(((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly())
+        .isSameAs(mByteBufferRef.getUnderlyingReferenceTestOnly());
 
     // no data parsed; ignore
     PooledByteBuffer pooledByteBuffer2 = mockPooledByteBuffer(210);
@@ -270,9 +269,8 @@ public void testNewResult_Intermediate_pJPEG() {
     inOrder.verify(mJobScheduler).updateJob(encodedImage2, Consumer.NO_FLAGS);
     inOrder.verify(mProgressiveJpegParser).parseMoreData(argumentCaptor.capture());
     inOrder.verify(mJobScheduler, never()).scheduleJob();
-    assertSame(
-        ((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly(),
-        ref2.getUnderlyingReferenceTestOnly());
+    assertThat(((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly())
+        .isSameAs(ref2.getUnderlyingReferenceTestOnly());
 
     // same scan; ignore
     PooledByteBuffer pooledByteBuffer3 = mockPooledByteBuffer(220);
@@ -285,9 +283,8 @@ public void testNewResult_Intermediate_pJPEG() {
     inOrder.verify(mJobScheduler).updateJob(encodedImage3, Consumer.NO_FLAGS);
     inOrder.verify(mProgressiveJpegParser).parseMoreData(argumentCaptor.capture());
     inOrder.verify(mJobScheduler, never()).scheduleJob();
-    assertSame(
-        ((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly(),
-        ref3.getUnderlyingReferenceTestOnly());
+    assertThat(((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly())
+        .isSameAs(ref3.getUnderlyingReferenceTestOnly());
 
     // scan not for decode; ignore
     PooledByteBuffer pooledByteBuffer4 = mockPooledByteBuffer(300);
@@ -300,9 +297,8 @@ public void testNewResult_Intermediate_pJPEG() {
     inOrder.verify(mJobScheduler).updateJob(encodedImage4, Consumer.NO_FLAGS);
     inOrder.verify(mProgressiveJpegParser).parseMoreData(argumentCaptor.capture());
     inOrder.verify(mJobScheduler, never()).scheduleJob();
-    assertSame(
-        ((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly(),
-        ref4.getUnderlyingReferenceTestOnly());
+    assertThat(((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly())
+        .isSameAs(ref4.getUnderlyingReferenceTestOnly());
 
     // good-enough scan; schedule
     PooledByteBuffer pooledByteBuffer5 = mockPooledByteBuffer(500);
@@ -315,9 +311,8 @@ public void testNewResult_Intermediate_pJPEG() {
     inOrder.verify(mJobScheduler).updateJob(encodedImage5, Consumer.NO_FLAGS);
     inOrder.verify(mProgressiveJpegParser).parseMoreData(argumentCaptor.capture());
     inOrder.verify(mJobScheduler).scheduleJob();
-    assertSame(
-        ((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly(),
-        ref5.getUnderlyingReferenceTestOnly());
+    assertThat(((EncodedImage) argumentCaptor.getValue()).getUnderlyingReferenceTestOnly())
+        .isSameAs(ref5.getUnderlyingReferenceTestOnly());
   }
 
   @Test
@@ -434,7 +429,7 @@ public void testDecode_WhenSmartResizingEnabledAndLocalUri_ThenPerformDownsampli
     jobRunnable.run(mEncodedImage, Consumer.IS_LAST);
 
     // The sample size was modified, which means Downsampling has been performed
-    assertNotEquals(mEncodedImage.getSampleSize(), EncodedImage.DEFAULT_SAMPLE_SIZE);
+    assertThat(mEncodedImage.getSampleSize()).isNotEqualTo(EncodedImage.DEFAULT_SAMPLE_SIZE);
   }
 
   @Test
@@ -450,7 +445,7 @@ public void testDecode_WhenDownsampleOverrideProvidedAndLocalUri_ThenPerformNoDo
     jobRunnable.run(mEncodedImage, Consumer.IS_LAST);
 
     // The sample size was not modified, which means Downsampling has not been performed
-    assertEquals(mEncodedImage.getSampleSize(), EncodedImage.DEFAULT_SAMPLE_SIZE);
+    assertThat(mEncodedImage.getSampleSize()).isEqualTo(EncodedImage.DEFAULT_SAMPLE_SIZE);
   }
 
   @Test
@@ -466,7 +461,7 @@ public void testDecode_WhenSmartResizingEnabledAndNetworkUri_ThenPerformNoDownsa
     jobRunnable.run(mEncodedImage, Consumer.IS_LAST);
 
     // The sample size was not modified, which means Downsampling has not been performed
-    assertEquals(mEncodedImage.getSampleSize(), EncodedImage.DEFAULT_SAMPLE_SIZE);
+    assertThat(mEncodedImage.getSampleSize()).isEqualTo(EncodedImage.DEFAULT_SAMPLE_SIZE);
   }
 
   @Test
@@ -483,7 +478,7 @@ public void testDecode_WhenDownsampleOverrideProvidedAndNetworkUri_ThenPerformNo
     jobRunnable.run(mEncodedImage, Consumer.IS_LAST);
 
     // The sample size was not modified, which means Downsampling has not been performed
-    assertEquals(mEncodedImage.getSampleSize(), EncodedImage.DEFAULT_SAMPLE_SIZE);
+    assertThat(mEncodedImage.getSampleSize()).isEqualTo(EncodedImage.DEFAULT_SAMPLE_SIZE);
   }
 
   private void setupImageRequest(String requestId, ImageRequest imageRequest) {