Missing ‘stopTimer()’ in the timer callback in foleys_ApplicationSettings.cpp

[freeeco]

Missing ‘stopTimer()’ in the timer callback in foleys_ApplicationSettings.cpp is causing a hang when using the MIDI learn function.

[ffAudio]

The Timer is not meant to be a one off. Instead the ApplicationSettings is checked every second. Only if it differs the settings are reloaded.
The reason is so you can use e.g. Midi learn in one plugin instance and the other will react to it.
Or like in the FoleysSynth example you can store presets there that are shared amongs all instances (as an alternative approach of files)

I didn't observe a hang, can you describe what you did to replicate the problem?

[freeeco]

Oh yeah, that makes sense now :)

I didn't observe a hang, can you describe what you did to replicate the problem?

If I drag and drop a CC onto a slider with the MIDI learn component in the FoleysSynth example, then the plugin hangs.

I added a breakpoint to the 'valueTreeChildAdded' callback in ApplicationSettings and it seems to continuously be being called, so maybe it's getting stuck in some kind of feedback loop?