Skip to content

Bug: network_error_code is an octet string which might as a string might have more than 3 characters #10

@williamsonrichard

Description

@williamsonrichard

In DeliveryReceipt, the value of a network_error_code is regarded invalid if it has more than 3 characters when converted to a string. However, the SMPP protocol allows more than 3 characters: the actual requirement is that we have an octet string of size three. When converted to a string, we might have more than three characters: eg, 0423 0003 0308 0200 is a valid hex network_error_code TLV, which will give err:2050, and a DeliveryReceiptException is thrown.

I don't see a straightforward way to fix this, because the DeliveryReceipt class is based upon parsing a string.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions