Add cpu_no_label, gpu_no_label, and fps_no_label #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Instead of adding options, treat an empty string with this behavior |
Author
I can give that a go. I was trying to match the "time_no_label" option. Are you thinking like: Right now that gives the following: |
Owner
|
Yeah that's what I was thinking, it should not have a column like you had designed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can currently change the labels for cpu/gpu/fps but not hide them. This change adds options (cpu_no_label, gpu_no_label, and fps_no_label) to hide the labels for a more minimal look. Intended mainly for horizontal layout, but can work in non-horizontal as well.
Before:
After:
Non-horizontal:
