Skip to content

Commit 47272c4

Browse files
authored
fix: pin docker-registry haSharedSecret to avoid sandbox manifest churn (#7108)
The docker-registry Helm subchart generates a random haSharedSecret on every helm template run when the value is not set. This causes complete.yaml and dev.yaml to always show as modified after running `make sandbox-build`, even with no actual deployment changes. Pin the secret to a static value in flyte-sandbox values.yaml since this is a local development sandbox environment. Signed-off-by: Kevin Su <pingsutw@apache.org>
1 parent 2731633 commit 47272c4

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

charts/flyte-sandbox/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ docker-registry:
55
pullPolicy: Never
66
persistence:
77
enabled: false
8+
secrets:
9+
haSharedSecret: flytesandboxsecret
810
service:
911
type: NodePort
1012
nodePort: 30000

docker/sandbox-bundled/manifests/complete.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,7 @@ type: Opaque
11121112
---
11131113
apiVersion: v1
11141114
data:
1115-
haSharedSecret: dk8yMDZDOTR6SHRrQUNrUQ==
1115+
haSharedSecret: Zmx5dGVzYW5kYm94c2VjcmV0
11161116
proxyPassword: ""
11171117
proxyUsername: ""
11181118
kind: Secret
@@ -1707,7 +1707,7 @@ spec:
17071707
metadata:
17081708
annotations:
17091709
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
1710-
checksum/secret: cf1faf39f000efb8810269147692898bc61a92952ded23c8145cc963dc8ca1b3
1710+
checksum/secret: 829c19e3c86dcb9b7d4c44e6a73463c6a6467d824200e87e2d7999f70dc0f5f9
17111711
labels:
17121712
app: docker-registry
17131713
release: flyte-sandbox

docker/sandbox-bundled/manifests/dev.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,7 @@ metadata:
826826
---
827827
apiVersion: v1
828828
data:
829-
haSharedSecret: eXNVaWVTRkFhdHNsS3V3RQ==
829+
haSharedSecret: Zmx5dGVzYW5kYm94c2VjcmV0
830830
proxyPassword: ""
831831
proxyUsername: ""
832832
kind: Secret
@@ -1323,7 +1323,7 @@ spec:
13231323
metadata:
13241324
annotations:
13251325
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
1326-
checksum/secret: a9f352bd07e84295ab41efa4e840927a884c894cab47f8a95c19e6e90393baaf
1326+
checksum/secret: 829c19e3c86dcb9b7d4c44e6a73463c6a6467d824200e87e2d7999f70dc0f5f9
13271327
labels:
13281328
app: docker-registry
13291329
release: flyte-sandbox

0 commit comments

Comments
 (0)