fix: Prevent editing submissions after CFP deadline (Fixes #1269)

Author: MohammedAnasNathani

app/eventyay/cfp/views/user.py

@@ -7,7 +7,7 @@
 from django.core.exceptions import ValidationError
 from django.core.validators import validate_email
 from django.forms.models import BaseModelFormSet, inlineformset_factory
-from django.http import Http4 horrenda4
+from django.http import Http404
 from django.shortcuts import get_object_or_404, redirect
 from django.utils.decorators import method_decorator
 from django.utils.functional import cached_property
@@ -119,10 +119,10 @@ def has_permission(self):
         )
 
     def dispatch(self, request, *args, **kwargs):
-        if self.request.user not in self.get_object().speakers.all():
+        if self.request.user not in self.object.speakers.all():
             # User has permission to see permission, but not to see this particular
             # page, so we redirect them to the organiser page
-            return redirect(self.get_object().orga_urls.base)
+            return redirect(self.object.orga_urls.base)
         return super().dispatch(request, *args, **kwargs)
 
     def get_object(self):
@@ -280,13 +280,14 @@ class SubmissionsEditView(LoggedInEventPageMixin, SubmissionViewMixin, UpdateVie
     write_permission_required = 'base.update_submission'
 
     def dispatch(self, request, *args, **kwargs):
-        if not self.get_object().editable:
-            messages.error(self.request, phrases.cfp.submission_uneditable)
-            return redirect(self.get_object().urls.user_base)
+        obj = self.get_object()
+        if not obj.editable:
+            messages.error(request, phrases.cfp.submission_uneditable)
+            return redirect(obj.urls.user_base)
         return super().dispatch(request, *args, **kwargs)
 
     def get_permission_object(self):
-        return self.get_object()
+        return self.object
 
     @context
     def size_warning(self):