Fix: Prevent Scroll-to-Top Behavior on Logout Click

[htssp]

Problem
When clicking the Logout option in the global navigation menu, the browser performs a default navigation action due to the href="#".
This causes the page to scroll to the top before logout is fully processed, leading to a poor user experience.

Solution Implemented
Replaced the logout <a href="#"> element with a semantic <button type="button">.

Preserved all UI styling by keeping the same utility classes

Added @click to block default navigation behavior

Logout behavior remains unchanged — handleLogout() still submits the form normally

Result

No scroll jump
No UI changes
Logout still works properly

Fixes #1437

Summary by Sourcery

Improve global navigation behavior and align supported locale lists across the application.

Bug Fixes:

• Prevent page scroll-to-top on logout by replacing the logout anchor with a button that no longer triggers default navigation.

Enhancements:

• Streamline and synchronize configured locale lists for moment.js and i18n helpers by removing unused or unsupported locales.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the logout anchor link in the global navigation with a semantic button to prevent scroll-to-top behavior while keeping behavior and styling intact, and synchronizes supported locale code lists across frontend (Vue) and backend (Python i18n helpers) by removing unused or unsupported locales.

Sequence diagram for logout click handling with button

sequenceDiagram
  actor User
  participant Browser
  participant GlobalNavMenu
  participant LogoutForm
  participant BackendAuth

  User->>Browser: Click Logout button
  Browser->>GlobalNavMenu: Dispatch click event
  GlobalNavMenu->>GlobalNavMenu: handleLogout
  GlobalNavMenu->>LogoutForm: Submit logout form
  LogoutForm->>BackendAuth: POST /logout
  BackendAuth-->>LogoutForm: 302 Redirect to login or home
  LogoutForm-->>Browser: Redirect response
  Browser-->>User: Render post logout page

  note over Browser,GlobalNavMenu: No default anchor navigation or scroll-to-top because element is a button type button without href

Loading

File-Level Changes

Change	Details	Files
Prevent scroll-to-top on logout by using a semantic button instead of an anchor while preserving existing styling and behavior.	Replace the logout element with a element in the global navigation menu component. Bind the existing click handler to the button so logout behavior remains unchanged. Reuse the same CSS utility class bindings to avoid visual/UI regressions.	app/eventyay/frontend/global-nav-menu/src/App.vue
Align and prune the set of supported Moment.js and backend locale codes to a consistent, smaller subset.	Remove several locale codes from the static Moment.js locale list used in the admin config view. Remove matching locale codes from the i18n helper whitelist used in the main app backend. Remove matching locale codes from the i18n helper whitelist used in the organizer app backend.	app/eventyay/webapp/src/views/admin/config/main.vue app/eventyay/helpers/i18n.py app/eventyay/orga/utils/i18n.py

Possibly linked issues

• #(not specified): PR replaces the logout anchor with a button, removing href="#" and eliminating the scroll-to-top behavior.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• The hard-coded locale lists are now duplicated across multiple files (Vue config and two Python helpers); consider extracting a single shared source of truth or generator to avoid future drift when adding/removing locales.
• The PR description mentions using @click.prevent on the logout control, but the implementation only uses @click; either update the description or add .prevent if you still expect it for consistency with other handlers.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The hard-coded locale lists are now duplicated across multiple files (Vue config and two Python helpers); consider extracting a single shared source of truth or generator to avoid future drift when adding/removing locales.
- The PR description mentions using `@click.prevent` on the logout control, but the implementation only uses `@click`; either update the description or add `.prevent` if you still expect it for consistency with other handlers.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[mariobehling]

You are changing i18 related files. Only change what is related to this issue in the PR.

[mariobehling]

This is probably related to a revert of several PRs which we had to make.