Skip to content

Commit 7b26c8d

Browse files
committed
Refactor logging setup by removing unnecessary references and simplifying logger configuration
1 parent c23efc4 commit 7b26c8d

File tree

4 files changed

+5
-16
lines changed

4 files changed

+5
-16
lines changed

Frank.Testing.TestBases/Frank.Testing.TestBases.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@
1010
<PackageReference Include="TUnit.Core" Version="0.19.74" />
1111
</ItemGroup>
1212

13-
<ItemGroup>
14-
<ProjectReference Include="..\Frank.Testing.Logging\Frank.Testing.Logging.csproj" />
15-
</ItemGroup>
16-
1713
<ItemGroup>
1814
<FrameworkReference Include="Microsoft.AspNetCore.App" />
1915
</ItemGroup>

Frank.Testing.TestBases/HostApplicationDependencyInjectionDataProviderAttributeBase.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using Frank.Testing.Logging;
2-
3-
using Microsoft.Extensions.DependencyInjection;
1+
using Microsoft.Extensions.DependencyInjection;
42
using Microsoft.Extensions.Hosting;
53
using Microsoft.Extensions.Logging;
64

@@ -26,7 +24,7 @@ private IHost CreateHost()
2624
{
2725
var builder = Microsoft.Extensions.Hosting.Host.CreateApplicationBuilder();
2826
builder = Setup(builder);
29-
builder.Logging.AddDebug().AddSimpleTestLogger();
27+
builder.Logging.AddDebug();
3028
return builder.Build();
3129
}
3230

Frank.Testing.TestBases/HostApplicationTestBase.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using Frank.Testing.Logging;
2-
3-
using Microsoft.Extensions.DependencyInjection;
1+
using Microsoft.Extensions.DependencyInjection;
42
using Microsoft.Extensions.Hosting;
53
using Microsoft.Extensions.Logging;
64
using Microsoft.Extensions.Logging.Abstractions;
@@ -26,7 +24,7 @@ public abstract class HostApplicationTestBase : IAsyncDisposable
2624
protected HostApplicationTestBase(LogLevel logLevel = LogLevel.Error, ILoggerProvider? loggerProvider = null)
2725
{
2826
_hostApplicationBuilder = Host.CreateApplicationBuilder();
29-
_hostApplicationBuilder.Logging.ClearProviders().AddDebug().AddProvider(TestContext.Current?.CreateTestLoggerProvider() ?? NullLoggerProvider.Instance).SetMinimumLevel(logLevel);
27+
_hostApplicationBuilder.Logging.ClearProviders().AddDebug().SetMinimumLevel(logLevel);
3028

3129
if (loggerProvider != null)
3230
{

Frank.Testing.TestBases/WebApplicationTestBase.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
using System.Net;
22

3-
using Frank.Testing.Logging;
4-
53
using Microsoft.AspNetCore.Builder;
64
using Microsoft.AspNetCore.Hosting;
75
using Microsoft.AspNetCore.Http;
86
using Microsoft.AspNetCore.Routing;
97
using Microsoft.Extensions.DependencyInjection;
108
using Microsoft.Extensions.Hosting;
119
using Microsoft.Extensions.Logging;
12-
using Microsoft.Extensions.Logging.Abstractions;
1310

1411
namespace Frank.Testing.TestBases;
1512

@@ -33,7 +30,7 @@ public class WebApplicationTestBase : IAsyncDisposable
3330
protected WebApplicationTestBase(LogLevel logLevel = LogLevel.Error, ILoggerProvider? loggerProvider = null)
3431
{
3532
_hostApplicationBuilder = WebApplication.CreateBuilder();
36-
_hostApplicationBuilder.Logging.ClearProviders().AddDebug().AddProvider(TestContext.Current?.CreateTestLoggerProvider() ?? NullLoggerProvider.Instance).SetMinimumLevel(logLevel);
33+
_hostApplicationBuilder.Logging.ClearProviders().AddDebug().SetMinimumLevel(logLevel);
3734

3835
if (loggerProvider != null)
3936
{

0 commit comments

Comments
 (0)