urls are not properly encoded in console

[ketas]

setting

BUILDNAME_FORMAT=%Y-%m-%d_%H-%M-%S_%z

(and probably other vars too)

to strings that produce url-invalid chars

causes urls in builder output to become invalid because nothing urlencodes those parameters

[bdrewery]

Example of invalid characters/URLs? I'm missing it.

[ketas]

in my case, "+". tz brings plus in. if you are this side of gmt, that is

urlencoding is difficult thing too but that url didn't lead me onto correct thing in poudriere

unless you argue that this was terminal / browser thing

actually js uses it on that side but + is space in almost everywhere i ever remember

well i don't know

i expect noone trying + there before

[ketas]

eg urls get into this:

build.html?mastername=13-5-release-armv7-local-minimal&build=2025-10-20_05-43-07_+0300

what's needed is:

build.html?mastername=13-5-release-armv7-local-minimal&build=2025-10-20_05-43-07_%2b0300

[ketas]

urlencode()
{
        local input="$1"
        local old_ifs
        local char
        local output=


        old_ifs="$IFS"
        IFS='
'

        for char in `echo -n "$input" | fold -b1`
        do
                case "$char"
                in
                        [a-zA-Z0-9.~_-]) output="$output$char" ;;
                        ' ') output="$output+" ;;
                        *) output="$output%`echo -n \"$char\" | xxd -p`" ;;
                esac
        done

        IFS="$old_ifs"


        echo -n "$output"
}

[ketas]

github broke it eh

[bdrewery]

Thank you for the code. Let's just handle the + to %2b for now. I can include an easy fix for that.