Update dependency electron to v39 (#1438)

dex4er · web-flow · commit a09f0d866d52 · 2025-12-03T22:31:14.000+01:00
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-22.16.0
+22.21.1
diff --git a/README.md b/README.md
@@ -41,7 +41,7 @@ download the right package for your system.
 
 ### macOS
 
-macOS 11 or later is required.
+macOS 12 or later is required.
 
 Download either the PKG (installer) or DMG (image) package from the
 [releases](https://github.com/freelensapp/freelens/releases) page. Both arm64
diff --git a/freelens/electron-builder.yml b/freelens/electron-builder.yml
@@ -1,6 +1,6 @@
 # yaml-language-server: $schema=https://raw.githubusercontent.com/electron-userland/electron-builder/refs/heads/master/packages/app-builder-lib/scheme.json
 
-electronVersion: 35.7.5 # datasource=npm depName=electron
+electronVersion: 39.2.4 # datasource=npm depName=electron
 
 ## Run `pnpm electron-rebuild` instead
 npmRebuild: false
diff --git a/freelens/package.json b/freelens/package.json
@@ -168,21 +168,22 @@
     "@types/fs-extra": "^11.0.4",
     "@types/jest": "^29.5.14",
     "@types/lodash": "^4.17.21",
-    "@types/node": "~22.16.5",
+    "@types/node": "~22.19.1",
     "@types/webpack-env": "^1.18.8",
     "circular-dependency-plugin": "^5.2.2",
     "copy-webpack-plugin": "^13.0.0",
     "css-loader": "^6.11.0",
-    "electron": "^35.7.5",
-    "electron-builder": "^26.0.12",
-    "electron-builder-squirrel-windows": "26.0.12",
+    "electron": "^39.2.4",
+    "electron-builder": "^26.3.2",
+    "electron-builder-squirrel-windows": "26.3.2",
     "fork-ts-checker-webpack-plugin": "^9.1.0",
     "html-webpack-plugin": "^5.6.3",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",
     "mini-css-extract-plugin": "^2.9.4",
     "monaco-editor-webpack-plugin": "^7.1.1",
+    "node-abi": "^4.24.0",
     "node-gyp": "12.1.0",
     "node-loader": "^2.1.0",
     "playwright": "^1.57.0",
diff --git a/knip.jsonc b/knip.jsonc
@@ -30,6 +30,8 @@
         "electron",
         // explicit dependency to prevent to install different versions of app-build-lib
         "electron-builder-squirrel-windows",
+        // it has to be explicitly updated together with electron
+        "node-abi",
         // explicit dependency to prevent using version from pnpm
         "node-gyp",
         // used as script to run in fork() to install extensions
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -208,7 +208,7 @@
     "@types/js-yaml": "^4.0.9",
     "@types/lodash": "^4.17.21",
     "@types/memorystream": "^0.3.4",
-    "@types/node": "~22.16.5",
+    "@types/node": "~22.19.1",
     "@types/proper-lockfile": "^4.1.4",
     "@types/randomcolor": "^0.5.9",
     "@types/react": "^17.0.90",
@@ -229,7 +229,7 @@
     "@types/ws": "^8.18.1",
     "circular-dependency-plugin": "^5.2.2",
     "css-loader": "^6.11.0",
-    "electron": "^35.7.5",
+    "electron": "^39.2.4",
     "fork-ts-checker-webpack-plugin": "^9.1.0",
     "glob": "^13.0.0",
     "identity-obj-proxy": "^3.0.0",
diff --git a/packages/core/src/common/app-paths/app-paths.test.ts b/packages/core/src/common/app-paths/app-paths.test.ts
@@ -23,6 +23,7 @@ describe("app-paths", () => {
     builder = getApplicationBuilder();
 
     const defaultAppPathsStub: AppPaths = {
+      assets: "/some-assets",
       currentApp: "/some-current-app",
       appData: "/some-app-data",
       crashDumps: "/some-crash-dumps",
diff --git a/packages/core/src/common/fs/exec-file.injectable.ts b/packages/core/src/common/fs/exec-file.injectable.ts
@@ -47,7 +47,7 @@ const execFileInjectable = getInjectable({
           } else {
             resolve({
               callWasSuccessful: true,
-              response: stdout,
+              response: stdout.toString(),
             });
           }
         });
diff --git a/packages/core/src/main/electron-app/electron-app.global-override-for-injectable.ts b/packages/core/src/main/electron-app/electron-app.global-override-for-injectable.ts
@@ -219,6 +219,19 @@ export default getGlobalOverride(electronAppInjectable, () => {
       void userInfo;
       throw new Error("Method not implemented.");
     }
+    getAccessibilitySupportFeatures(): string[] {
+      throw new Error("Method not implemented.");
+    }
+    getRecentDocuments(): string[] {
+      throw new Error("Method not implemented.");
+    }
+    isHardwareAccelerationEnabled(): boolean {
+      throw new Error("Method not implemented.");
+    }
+    setAccessibilitySupportFeatures(features: string[]): void {
+      void features;
+      throw new Error("Method not implemented.");
+    }
 
     resolveProxy(url: string): Promise<string> {
       void url;
@@ -232,7 +245,7 @@ export default getGlobalOverride(electronAppInjectable, () => {
       throw new Error("Method not implemented.");
     }
 
-    setProxy(config: ProxyConfig): void {
+    setProxy(config: ProxyConfig): Promise<void> {
       void config;
       throw new Error("Method not implemented.");
     }
diff --git a/packages/core/src/main/start-main-application/runnables/setup-hostnames.injectable.ts b/packages/core/src/main/start-main-application/runnables/setup-hostnames.injectable.ts
@@ -16,7 +16,7 @@ const setupHostnamesInjectable = getInjectable({
       const app = di.inject(electronAppInjectable);
 
       app.commandLine.appendSwitch(
-        "host-rules",
+        "host-resolver-rules",
         [
           "MAP localhost 127.0.0.1",
           "MAP renderer.freelens.app 127.0.0.1",
diff --git a/packages/core/src/renderer/components/extensions/install-on-drop.injectable.ts b/packages/core/src/renderer/components/extensions/install-on-drop.injectable.ts
@@ -8,7 +8,12 @@ import { loggerInjectionToken } from "@freelensapp/logger";
 import { getInjectable } from "@ogre-tools/injectable";
 import attemptInstallsInjectable from "./attempt-installs.injectable";
 
-export type InstallOnDrop = (files: File[]) => Promise<void>;
+// Electron extends the browser File interface with a path property
+interface FileWithPath extends File {
+  path: string;
+}
+
+export type InstallOnDrop = (files: FileWithPath[]) => Promise<void>;
 
 const installOnDropInjectable = getInjectable({
   id: "install-on-drop",
diff --git a/packages/core/src/renderer/components/file-picker/file-picker.tsx b/packages/core/src/renderer/components/file-picker/file-picker.tsx
@@ -184,7 +184,8 @@ class DefaultedFilePicker extends React.Component<FilePickerProps & typeof defau
 
           paths.push(destinationPath);
 
-          return fse.copyFile(file.path, destinationPath);
+          const buffer = await file.arrayBuffer();
+          return fse.writeFile(destinationPath, Buffer.from(buffer));
         });
 
         await Promise.all(promises);
diff --git a/packages/ensure-binaries/package.json b/packages/ensure-binaries/package.json
@@ -30,7 +30,7 @@
   "devDependencies": {
     "@types/cli-progress": "^3.11.6",
     "@types/gunzip-maybe": "^1.4.3",
-    "@types/node": "~22.16.5",
+    "@types/node": "~22.19.1",
     "@types/tar-stream": "^3.1.4",
     "typescript": "^5.9.3"
   },
diff --git a/packages/extensions/package.json b/packages/extensions/package.json
@@ -30,7 +30,7 @@
     "@freelensapp/core": "workspace:^"
   },
   "devDependencies": {
-    "@types/node": "~22.16.5",
+    "@types/node": "~22.19.1",
     "ts-loader": "^9.5.4",
     "ts-node": "^10.9.2",
     "typescript": "^5.9.3",
diff --git a/packages/generate-tray-icons/package.json b/packages/generate-tray-icons/package.json
@@ -27,7 +27,7 @@
   "devDependencies": {
     "@freelensapp/icon": "workspace:^",
     "@types/jsdom": "^27.0.0",
-    "@types/node": "~22.16.5",
+    "@types/node": "~22.19.1",
     "typescript": "^5.9.3"
   },
   "bin": {
diff --git a/packages/semver/package.json b/packages/semver/package.json
@@ -17,7 +17,7 @@
   },
   "devDependencies": {
     "@types/command-line-args": "^5.2.3",
-    "@types/node": "~22.16.5",
+    "@types/node": "~22.19.1",
     "@types/semver": "^7.7.1",
     "typescript": "^5.9.3"
   }
diff --git a/packages/technical-features/application/application-for-electron-main/package.json b/packages/technical-features/application/application-for-electron-main/package.json
@@ -35,7 +35,7 @@
     "@freelensapp/run-many": "workspace:^",
     "@ogre-tools/injectable": "^17.11.1",
     "@ogre-tools/injectable-extension-for-auto-registration": "^17.11.1",
-    "electron": "^35.7.5"
+    "electron": "^39.2.4"
   },
   "devDependencies": {
     "@async-fn/jest": "^1.6.4",
diff --git a/packages/technical-features/messaging/messaging-for-main/package.json b/packages/technical-features/messaging/messaging-for-main/package.json
@@ -35,7 +35,7 @@
     "@ogre-tools/fp": "^17.11.1",
     "@ogre-tools/injectable": "^17.11.1",
     "@ogre-tools/injectable-extension-for-auto-registration": "^17.11.1",
-    "electron": "^35.7.5",
+    "electron": "^39.2.4",
     "lodash": "^4.17.21"
   },
   "devDependencies": {
@@ -45,7 +45,6 @@
     "@freelensapp/typescript": "workspace:^",
     "@freelensapp/webpack": "workspace:^",
     "@types/webpack-env": "^1.18.8",
-    "electron": "^35.7.5",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "ts-jest": "^29.4.5",
diff --git a/packages/technical-features/messaging/messaging-for-renderer/package.json b/packages/technical-features/messaging/messaging-for-renderer/package.json
@@ -35,7 +35,7 @@
     "@freelensapp/messaging": "workspace:^",
     "@ogre-tools/injectable": "^17.11.1",
     "@ogre-tools/injectable-extension-for-auto-registration": "^17.11.1",
-    "electron": "^35.7.5"
+    "electron": "^39.2.4"
   },
   "devDependencies": {
     "@async-fn/jest": "^1.6.4",
diff --git a/packages/utility-features/json-api/package.json b/packages/utility-features/json-api/package.json
@@ -41,7 +41,7 @@
     "@freelensapp/typescript": "workspace:^",
     "@freelensapp/webpack": "workspace:^",
     "@types/lodash": "^4.17.21",
-    "@types/node": "~22.16.5",
+    "@types/node": "~22.19.1",
     "rfc6902": "^5.1.2",
     "ts-loader": "^9.5.4",
     "type-fest": "^5.2.0",
diff --git a/packages/utility-features/test-utils/package.json b/packages/utility-features/test-utils/package.json
@@ -39,7 +39,7 @@
     "@freelensapp/webpack": "workspace:^",
     "@types/jest": "^29.5.14",
     "@types/lodash": "^4.17.21",
-    "@types/node": "~22.16.5",
+    "@types/node": "~22.19.1",
     "@types/react": "^17.0.90",
     "react-dom": "^17.0.2",
     "ts-loader": "^9.5.4",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ const execFileInjectable = getInjectable({`
`47`	`47`	`} else {`
`48`	`48`	`resolve({`
`49`	`49`	`callWasSuccessful: true,`
`50`		`- response: stdout,`
	`50`	`+ response: stdout.toString(),`
`51`	`51`	`});`
`52`	`52`	`}`
`53`	`53`	`});`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ const setupHostnamesInjectable = getInjectable({`
`16`	`16`	`const app = di.inject(electronAppInjectable);`
`17`	`17`
`18`	`18`	`app.commandLine.appendSwitch(`
`19`		`- "host-rules",`
	`19`	`+ "host-resolver-rules",`
`20`	`20`	`[`
`21`	`21`	`"MAP localhost 127.0.0.1",`
`22`	`22`	`"MAP renderer.freelens.app 127.0.0.1",`