Fixed incorrent cache updating when adding permission overwrites

Author: gehongyan

samples/Kook.Net.Samples.TextCommands/Modules/PublicModule.cs

@@ -116,13 +116,10 @@ public async Task ModifyCategoryPermissions()
         await guildChannel.AddPermissionOverwriteAsync((IGuildUser)Context.User);
         if (guildChannel is SocketChannel socketChannel)
             await socketChannel.UpdateAsync();
-        if (guild.GetChannel(Context.Channel.Id) is { } socketGuildChannel)
-        {
-            await socketGuildChannel.ModifyPermissionOverwriteAsync((IGuildUser)Context.User,
-                permissions => permissions.Modify(
-                    viewChannel: PermValue.Allow,
-                    sendMessages: PermValue.Deny,
-                    attachFiles: PermValue.Allow));
-        }
+        await guildChannel.ModifyPermissionOverwriteAsync((IGuildUser)Context.User,
+            permissions => permissions.Modify(
+                viewChannel: PermValue.Allow,
+                sendMessages: PermValue.Deny,
+                attachFiles: PermValue.Allow));
     }
 }

src/Kook.Net.Rest/Entities/Channels/RestGuildChannel.cs

@@ -129,19 +129,19 @@ public override async Task UpdateAsync(RequestOptions? options = null)
     /// <inheritdoc cref="Kook.IGuildChannel.AddPermissionOverwriteAsync(Kook.IGuildUser,Kook.RequestOptions)" />
     public async Task AddPermissionOverwriteAsync(IGuildUser user, RequestOptions? options = null)
     {
-        UserPermissionOverwrite permissionOverwrite = await ChannelHelper
+        UserPermissionOverwrite perms = await ChannelHelper
             .AddPermissionOverwriteAsync(this, Kook, user, options)
             .ConfigureAwait(false);
-        _userPermissionOverwrites = [.._userPermissionOverwrites, permissionOverwrite];
+        _userPermissionOverwrites = [.._userPermissionOverwrites.Where(x => x.TargetId != perms.TargetId), perms];
     }
 
     /// <inheritdoc cref="Kook.IGuildChannel.AddPermissionOverwriteAsync(Kook.IRole,Kook.RequestOptions)" />
     public async Task AddPermissionOverwriteAsync(IRole role, RequestOptions? options = null)
     {
-        RolePermissionOverwrite permissionOverwrite = await ChannelHelper
+        RolePermissionOverwrite perms = await ChannelHelper
             .AddPermissionOverwriteAsync(this, Kook, role, options)
             .ConfigureAwait(false);
-        _rolePermissionOverwrites = [.._rolePermissionOverwrites, permissionOverwrite];
+        _rolePermissionOverwrites = [.._rolePermissionOverwrites.Where(x => x.TargetId != perms.TargetId), perms];
     }
 
     /// <inheritdoc cref="Kook.IGuildChannel.RemovePermissionOverwriteAsync(Kook.IGuildUser,Kook.RequestOptions)" />

src/Kook.Net.WebSocket/Entities/Channels/SocketGuildChannel.cs

@@ -118,7 +118,7 @@ public async Task AddPermissionOverwriteAsync(IGuildUser user, RequestOptions? o
         UserPermissionOverwrite perms = await ChannelHelper
             .AddPermissionOverwriteAsync(this, Kook, user, options)
             .ConfigureAwait(false);
-        _userPermissionOverwrites = [.._userPermissionOverwrites, perms];
+        _userPermissionOverwrites = [.._userPermissionOverwrites.Where(x => x.TargetId != perms.TargetId), perms];
     }
 
     /// <inheritdoc cref="Kook.IGuildChannel.AddPermissionOverwriteAsync(Kook.IRole,Kook.RequestOptions)" />
@@ -127,7 +127,7 @@ public async Task AddPermissionOverwriteAsync(IRole role, RequestOptions? option
         RolePermissionOverwrite perms = await ChannelHelper
             .AddPermissionOverwriteAsync(this, Kook, role, options)
             .ConfigureAwait(false);
-        _rolePermissionOverwrites = [.._rolePermissionOverwrites, perms];
+        _rolePermissionOverwrites = [.._rolePermissionOverwrites.Where(x => x.TargetId != perms.TargetId), perms];
     }
 
     /// <inheritdoc cref="Kook.IGuildChannel.RemovePermissionOverwriteAsync(Kook.IGuildUser,Kook.RequestOptions)" />