Apply suggestions from code review

HaudinFlorence · martinRenou · web-flow · commit 0459a3048e85 · 2025-06-17T16:31:47.000+02:00
Co-authored-by: martinRenou &lt;martin.renou@gmail.com&gt;
diff --git a/packages/base/src/mainview/mainView.tsx b/packages/base/src/mainview/mainView.tsx
@@ -97,7 +97,7 @@ import { MainViewModel } from './mainviewmodel';
 //import Modify from 'ol/interaction/Modify.js';
 //import Snap from 'ol/interaction/Snap.js';
 
-const drawGeometries = ['Point', 'LineString', 'Polygon'];
+const DRAW_GEOMETRIES = ['Point', 'LineString', 'Polygon'] as const;
 
 interface IProps {
   viewModel: MainViewModel;
diff --git a/packages/schema/src/model.ts b/packages/schema/src/model.ts
@@ -810,8 +810,8 @@ export class JupyterGISModel implements IJupyterGISModel {
   private _geolocation: JgisCoordinates;
   private _geolocationChanged = new Signal<this, JgisCoordinates>(this);
 
-  public isDrawVectorLayerEnabled: boolean;
-  public drawVectorLayerChanged = new Signal<this, boolean>(this);
+  private editingVectorLayer: boolean;
+  private editingVectorLayerChanged = new Signal<this, boolean>(this);
 }
 
 export namespace JupyterGISModel {

Original file line number	Diff line number	Diff line change
`@@ -810,8 +810,8 @@ export class JupyterGISModel implements IJupyterGISModel {`
`810`	`810`	`private _geolocation: JgisCoordinates;`
`811`	`811`	`private _geolocationChanged = new Signal<this, JgisCoordinates>(this);`
`812`	`812`
`813`		`- public isDrawVectorLayerEnabled: boolean;`
`814`		`- public drawVectorLayerChanged = new Signal<this, boolean>(this);`
	`813`	`+ private editingVectorLayer: boolean;`
	`814`	`+ private editingVectorLayerChanged = new Signal<this, boolean>(this);`
`815`	`815`	`}`
`816`	`816`
`817`	`817`	`export namespace JupyterGISModel {`