chore: Rename Carthage validation project to XCFramework validation project

Author: itaybre

.github/workflows/release.yml

@@ -127,6 +127,9 @@ jobs:
           pattern: xcframework-${{github.sha}}-sentry-swiftui
           path: Carthage/
       - run: ./scripts/ci-select-xcode.sh 16.4
+      - name: Unzip all XCFrameworks
+        run: |
+          find Carthage -name "*.xcframework.zip" -print0 | xargs -t0I @ unzip @ -d Carthage
       - run: make build-xcframework-sample
       - name: Run CI Diagnostics
         if: failure()

.gitignore

@@ -44,8 +44,6 @@ Packages
 Carthage/Build
 Carthage/Checkouts
 Carthage
-Sentry.Carthage.json
-SentrySwiftUI.Carthage.json
 
 # CocoaPods
 Examples/**/Pods

Makefile

@@ -18,7 +18,7 @@ init-local:
 init-ci-build:
 	brew bundle --file Brewfile-ci-build
 
-# installs the tools needed to run CI deploy tasks locally (note that carthage is preinstalled in github actions)
+# installs the tools needed to run CI deploy tasks locally
 .PHONY: init-ci-deploy
 init-ci-deploy:
 	brew bundle --file Brewfile-ci-deploy
@@ -131,21 +131,16 @@ analyze:
 		exit 1; \
 	fi
 
-# Since Carthage 0.38.0 we need to create separate .framework.zip and .xcframework.zip archives.
-# After creating the zips we create a JSON to be able to test Carthage locally.
-# For more info check out: https://github.com/Carthage/Carthage/releases/tag/0.38.0
 build-xcframework:
-	@echo "--> Carthage: creating Sentry xcframework"
+	@echo "--> Creating Sentry xcframework"
 	./scripts/build-xcframework-local.sh | tee build-xcframework.log
 
 build-signed-xcframework:
-	@echo "--> Carthage: creating Signed Sentry xcframework"
+	@echo "--> Creating Signed Sentry xcframework"
 	./scripts/build-xcframework-local.sh | tee build-xcframework.log
 
 build-xcframework-sample:
-	./scripts/create-carthage-json.sh
-	cd Samples/Carthage-Validation/XCFramework/ && carthage update --use-xcframeworks
-	xcodebuild -project "Samples/Carthage-Validation/XCFramework/XCFramework.xcodeproj" -configuration Release CODE_SIGNING_ALLOWED="NO" build
+	xcodebuild -project "Samples/XCFramework-Validation/XCFramework/XCFramework.xcodeproj" -configuration Release CODE_SIGNING_ALLOWED="NO" build
 
 # call this like `make bump-version TO=5.0.0-rc.0`
 bump-version: clean-version-bump

Samples/Carthage-Validation/README.md

@@ -3,7 +3,7 @@
 	archiveVersion = 1;
 	classes = {
 	};
-	objectVersion = 52;
+	objectVersion = 60;
 	objects = {
 
 /* Begin PBXBuildFile section */
@@ -36,7 +36,7 @@
 /* End PBXCopyFilesBuildPhase section */
 
 /* Begin PBXFileReference section */
-		1573CAE22BBCA4820018A2B7 /* SentrySwiftUI.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = SentrySwiftUI.xcframework; path = Carthage/Build/SentrySwiftUI.xcframework; sourceTree = "<group>"; };
+		1573CAE22BBCA4820018A2B7 /* SentrySwiftUI.xcframework */ = {isa = PBXFileReference; expectedSignature = "AppleDeveloperProgram:97JCY7859U:GetSentry LLC"; lastKnownFileType = wrapper.xcframework; name = SentrySwiftUI.xcframework; path = ../../Carthage/SentrySwiftUI.xcframework; sourceTree = "<group>"; };
 		1573CAE62BBCA8260018A2B7 /* CheckTracedView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CheckTracedView.swift; sourceTree = "<group>"; };
 		7BA13E2E267B3F5200DEE308 /* XCFramework.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = XCFramework.app; sourceTree = BUILT_PRODUCTS_DIR; };
 		7BA13E31267B3F5200DEE308 /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
@@ -46,7 +46,7 @@
 		7BA13E3A267B3F5400DEE308 /* Preview Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = "Preview Assets.xcassets"; sourceTree = "<group>"; };
 		7BA13E3D267B3F5400DEE308 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/LaunchScreen.storyboard; sourceTree = "<group>"; };
 		7BA13E3F267B3F5400DEE308 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
-		7BA13E46267B4A2D00DEE308 /* Sentry.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = Sentry.xcframework; path = Carthage/Build/Sentry.xcframework; sourceTree = "<group>"; };
+		7BA13E46267B4A2D00DEE308 /* Sentry.xcframework */ = {isa = PBXFileReference; expectedSignature = "AppleDeveloperProgram:97JCY7859U:GetSentry LLC"; lastKnownFileType = wrapper.xcframework; name = Sentry.xcframework; path = ../../Carthage/Sentry.xcframework; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */