fix lo level filtering

Author: denrase

3rd-party-integrations/SentryCocoaLumberjack/README.md

@@ -29,7 +29,7 @@ SentrySDK.start { options in
     options.enableLogs = true
 }
 
-DDLog.add(SentryCocoaLumberjackLogger())
+DDLog.addLogger(SentryCocoaLumberjackLogger(), withLogLevel: .info)
 
 DDLogInfo("User logged in")
 DDLogError("Payment failed")
@@ -42,14 +42,13 @@ DDLogVerbose("Detailed trace information")
 
 ### Log Level Threshold
 
-Set the minimum log level for messages to be sent to Sentry:
+Use CocoaLumberjack's built-in filtering API when adding the logger to set the minimum log level for messages to be sent to Sentry:
 
 ```swift
-DDLog.add(SentryCocoaLumberjackLogger(logLevel: .verbose))
+// Only send error logs to Sentry
+DDLog.addLogger(SentryCocoaLumberjackLogger(), withLogLevel: .error)
 ```
 
-Messages below the configured threshold will be filtered out and not sent to Sentry.
-
 ## Log Level Mapping
 
 CocoaLumberjack log levels are automatically mapped to Sentry log levels:

3rd-party-integrations/SentryCocoaLumberjack/Sources/SentryCocoaLumberjackLogger.swift

@@ -8,8 +8,11 @@ import Sentry
 /// application logs from CocoaLumberjack and send them to Sentry for analysis and monitoring.
 ///
 /// ## Level Filtering
-/// The logger supports filtering by log level. Only logs at or above the configured `logLevel` will be
-/// sent to Sentry. Defaults to `.info`.
+/// Use CocoaLumberjack's built-in filtering API when adding the logger:
+/// ```swift
+/// DDLog.addLogger(SentryCocoaLumberjackLogger(), withLogLevel: .info)
+/// ```
+/// This ensures only logs at or above the specified level are sent to Sentry.
 ///
 /// ## Level Mapping
 /// CocoaLumberjack log levels are mapped to Sentry log levels:
@@ -32,7 +35,7 @@ import Sentry
 ///
 /// // Add SentryCocoaLumberjackLogger to CocoaLumberjack
 /// // Only logs at .info level and above will be sent to Sentry
-/// DDLog.add(SentryCocoaLumberjackLogger(logLevel: .info))
+/// DDLog.addLogger(SentryCocoaLumberjackLogger(), withLogLevel: .info)
 ///
 /// // Use CocoaLumberjack as usual
 /// DDLogInfo("User logged in")
@@ -43,39 +46,18 @@ import Sentry
 /// - Warning: This logger requires Sentry SDK to be initialized before use.
 public class SentryCocoaLumberjackLogger: DDAbstractLogger {
 
-    private let sentryLogger: SentryLogger
-    
-    /// The minimum log level for messages to be sent to Sentry.
-    ///
-    /// Messages below this level will be filtered out and not sent to Sentry.
-    /// Defaults to `.info`.
-    public var logLevel: DDLogLevel
-    
     /// Creates a new SentryCocoaLumberjackLogger instance.
     ///
-    /// - Parameter logLevel: The minimum log level for messages to be sent to Sentry.
-    ///   Defaults to `.info`.
     /// - Note: Make sure to initialize the Sentry SDK before creating this logger.
-    public init(logLevel: DDLogLevel = .info) {
-        self.sentryLogger = SentrySDK.logger
-        self.logLevel = logLevel
-        super.init()
-    }
-    
-    init(logLevel: DDLogLevel = .info, sentryLogger: SentryLogger) {
-        self.sentryLogger = sentryLogger
-        self.logLevel = logLevel
+    ///   Use `DDLog.addLogger(_:withLogLevel:)` to configure log level filtering.
+    public init() {
         super.init()
     }
 
     /// Logs a message from CocoaLumberjack to Sentry.
     ///
     /// - Parameter logMessage: The log message from CocoaLumberjack containing the message, level, and metadata.
     public override func log(message logMessage: DDLogMessage) {
-        guard logMessage.level.rawValue <= logLevel.rawValue else {
-            return
-        }
-        
         var attributes: [String: Any] = [:]
         attributes["sentry.origin"] = "auto.logging.cocoalumberjack"
 
@@ -100,17 +82,17 @@ public class SentryCocoaLumberjackLogger: DDAbstractLogger {
 
     private func forwardToSentry(message: String, flag: DDLogFlag, attributes: [String: Any]) {
         if flag.contains(.error) {
-            sentryLogger.error(message, attributes: attributes)
+            SentrySDK.logger.error(message, attributes: attributes)
         } else if flag.contains(.warning) {
-            sentryLogger.warn(message, attributes: attributes)
+            SentrySDK.logger.warn(message, attributes: attributes)
         } else if flag.contains(.info) {
-            sentryLogger.info(message, attributes: attributes)
+            SentrySDK.logger.info(message, attributes: attributes)
         } else if flag.contains(.debug) {
-            sentryLogger.debug(message, attributes: attributes)
+            SentrySDK.logger.debug(message, attributes: attributes)
         } else if flag.contains(.verbose) {
-            sentryLogger.trace(message, attributes: attributes)
+            SentrySDK.logger.trace(message, attributes: attributes)
         } else {
-            sentryLogger.info(message, attributes: attributes)
+            SentrySDK.logger.info(message, attributes: attributes)
         }
     }
 

3rd-party-integrations/SentryCocoaLumberjack/Tests/SentryCocoaLumberjackLoggerTests.swift

@@ -28,8 +28,8 @@ final class SentryCocoaLumberjackLoggerTests: XCTestCase {
         capturedLogs = []
     }
 
-    private func getSut(logLevel: DDLogLevel = .all) -> SentryCocoaLumberjackLogger {
-        return SentryCocoaLumberjackLogger(logLevel: logLevel)
+    private func getSut() -> SentryCocoaLumberjackLogger {
+        return SentryCocoaLumberjackLogger()
     }
 
     // MARK: - Basic Logging Tests
@@ -291,85 +291,6 @@ final class SentryCocoaLumberjackLoggerTests: XCTestCase {
         XCTAssertEqual(timestampValue, 1_234_567_890.123, accuracy: 0.001)
     }
 
-    // MARK: - Log Level Filtering Tests
-    
-    func testLogLevel_FiltersDebugWhenSetToInfo() {
-        let sut = getSut(logLevel: .info)
-        
-        let debugMessage = DDLogMessage(
-            format: "Debug message",
-            formatted: "Debug message",
-            level: .debug,
-            flag: .debug,
-            context: 0,
-            file: "TestFile.swift",
-            function: "testFunction",
-            line: 10,
-            tag: nil,
-            options: [],
-            timestamp: Date()
-        )
-        
-        sut.log(message: debugMessage)
-        
-        XCTAssertEqual(capturedLogs.count, 0, "Debug message should be filtered out when log level is .info")
-    }
-    
-    func testLogLevel_AllowsInfoWhenSetToInfo() {
-        let sut = getSut(logLevel: .info)
-        
-        let infoMessage = DDLogMessage(
-            format: "Info message",
-            formatted: "Info message",
-            level: .info,
-            flag: .info,
-            context: 0,
-            file: "TestFile.swift",
-            function: "testFunction",
-            line: 10,
-            tag: nil,
-            options: [],
-            timestamp: Date()
-        )
-        
-        sut.log(message: infoMessage)
-        
-        XCTAssertEqual(capturedLogs.count, 1, "Info message should be logged when log level is .info")
-    }
-    
-    func testLogLevel_AllowsErrorWhenSetToInfo() {
-        let sut = getSut(logLevel: .info)
-        
-        let errorMessage = DDLogMessage(
-            format: "Error message",
-            formatted: "Error message",
-            level: .error,
-            flag: .error,
-            context: 0,
-            file: "TestFile.swift",
-            function: "testFunction",
-            line: 10,
-            tag: nil,
-            options: [],
-            timestamp: Date()
-        )
-        
-        sut.log(message: errorMessage)
-        
-        XCTAssertEqual(capturedLogs.count, 1, "Error message should be logged when log level is .info")
-    }
-    
-    func testLogLevelConfiguration() {
-        let sut = getSut()
-        XCTAssertEqual(sut.logLevel, .all)
-        
-        sut.logLevel = .info
-        XCTAssertEqual(sut.logLevel, .info)
-        
-        sut.logLevel = .error
-        XCTAssertEqual(sut.logLevel, .error)
-    }
-    
     // MARK: - Helper Methods
 
     private func assertLogCaptured(