remove fixture

Author: denrase

Tests/SentryTests/Integrations/Log/FlushLogsIntegrationTests.swift

@@ -5,37 +5,27 @@ import XCTest
 #if os(iOS) || os(tvOS) || targetEnvironment(macCatalyst)
 final class FlushLogsIntegrationTests: XCTestCase {
 
-    private class Fixture {
-        let options: Options
-        let client: TestClient
-        let hub: SentryHubInternal
-        let dependencies: SentryDependencyContainer
-        let notificationCenterWrapper: TestNSNotificationCenterWrapper
-        
-        init() throws {
-            options = Options()
-            options.dsn = TestConstants.dsnForTestCase(type: FlushLogsIntegrationTests.self)
-            options.enableLogs = true
-            
-            client = TestClient(options: options)!
-            hub = TestHub(client: client, andScope: nil)
-            dependencies = SentryDependencyContainer.sharedInstance()
-            notificationCenterWrapper = TestNSNotificationCenterWrapper()
-            dependencies.notificationCenterWrapper = notificationCenterWrapper
-        }
-        
-        func getSut() -> FlushLogsIntegration<SentryDependencyContainer>? {
-            return FlushLogsIntegration(with: options, dependencies: dependencies)
-        }
-    }
-    
-    private var fixture: Fixture!
+    private var options: Options!
+    private var client: TestClient!
+    private var hub: SentryHubInternal!
+    private var dependencies: SentryDependencyContainer!
+    private var notificationCenterWrapper: TestNSNotificationCenterWrapper!
     private var sut: FlushLogsIntegration<SentryDependencyContainer>?
 
     override func setUpWithError() throws {
         try super.setUpWithError()
-        fixture = try Fixture()
-        SentrySDKInternal.setCurrentHub(fixture.hub)
+        
+        options = Options()
+        options.dsn = TestConstants.dsnForTestCase(type: FlushLogsIntegrationTests.self)
+        options.enableLogs = true
+        
+        client = TestClient(options: options)!
+        hub = TestHub(client: client, andScope: nil)
+        dependencies = SentryDependencyContainer.sharedInstance()
+        notificationCenterWrapper = TestNSNotificationCenterWrapper()
+        dependencies.notificationCenterWrapper = notificationCenterWrapper
+        
+        SentrySDKInternal.setCurrentHub(hub)
     }
 
     override func tearDown() {
@@ -45,61 +35,61 @@ final class FlushLogsIntegrationTests: XCTestCase {
     }
 
     func testInstall_Success() {
-        sut = fixture.getSut()
+        sut = FlushLogsIntegration(with: options, dependencies: dependencies)
         XCTAssertNotNil(sut)
     }
 
     func testInstall_FailsWhenLogsDisabled() {
-        fixture.options.enableLogs = false
-        sut = fixture.getSut()
+        options.enableLogs = false
+        sut = FlushLogsIntegration(with: options, dependencies: dependencies)
 
         XCTAssertNil(sut)
     }
 
     func testName_ReturnsCorrectName() {
-        sut = fixture.getSut()
+        sut = FlushLogsIntegration(with: options, dependencies: dependencies)
 
         XCTAssertEqual(FlushLogsIntegration<SentryDependencyContainer>.name, "FlushLogsIntegration")
     }
 
     func testWillResignActive_FlushesLogs() {
-        sut = fixture.getSut()
+        sut = FlushLogsIntegration(with: options, dependencies: dependencies)
 
-        fixture.notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willResignActiveNotification))
+        notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willResignActiveNotification))
 
-        XCTAssertEqual(fixture.client.captureLogsInvocations.count, 1)
+        XCTAssertEqual(client.captureLogsInvocations.count, 1)
     }
 
     func testWillTerminate_FlushesLogs() {
-        sut = fixture.getSut()
+        sut = FlushLogsIntegration(with: options, dependencies: dependencies)
 
-        fixture.notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willTerminateNotification))
+        notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willTerminateNotification))
 
-        XCTAssertEqual(fixture.client.captureLogsInvocations.count, 1)
+        XCTAssertEqual(client.captureLogsInvocations.count, 1)
     }
 
     func testUninstall_RemovesObservers() {
-        guard let sut = fixture.getSut()else {
+        guard let sut = FlushLogsIntegration(with: options, dependencies: dependencies) else {
             XCTFail("Integration should be initialized")
             return
         }
         sut.uninstall()
 
-        fixture.notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willResignActiveNotification))
-        fixture.notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willTerminateNotification))
+        notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willResignActiveNotification))
+        notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willTerminateNotification))
 
         // Should not flush logs after uninstall
-        XCTAssertEqual(fixture.client.captureLogsInvocations.count, 0)
+        XCTAssertEqual(client.captureLogsInvocations.count, 0)
     }
 
     func testMultipleNotifications_FlushesLogsMultipleTimes() {
-        sut = fixture.getSut()
+        sut = FlushLogsIntegration(with: options, dependencies: dependencies)
 
-        fixture.notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willResignActiveNotification))
-        fixture.notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willTerminateNotification))
-        fixture.notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willResignActiveNotification))
+        notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willResignActiveNotification))
+        notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willTerminateNotification))
+        notificationCenterWrapper.post(Notification(name: CrossPlatformApplication.willResignActiveNotification))
 
-        XCTAssertEqual(fixture.client.captureLogsInvocations.count, 3)
+        XCTAssertEqual(client.captureLogsInvocations.count, 3)
     }
 }
 #endif // os(iOS) || os(tvOS) || targetEnvironment(macCatalyst)