PR comments

Author: noahsmartin

Sources/Swift/Core/MetricKit/MXSample.swift

@@ -11,13 +11,5 @@ struct MXSample {
         let offsetIntoBinaryTextSegment: Int
         let binaryName: String?
         let address: UInt64
-        
-        func toSentryFrame() -> Frame {
-            let frame = Frame()
-            frame.package = binaryName
-            frame.instructionAddress = sentry_formatHexAddressUInt64Swift(address)
-            frame.imageAddress = sentry_formatHexAddressUInt64Swift(address - UInt64(offsetIntoBinaryTextSegment))
-            return frame
-        }
     }
 }

Sources/Swift/Core/MetricKit/SentryMXCallStackTree+Parsing.swift

@@ -90,23 +90,24 @@ extension SentryMXFrame {
     }
 }
 
-extension Sequence {
+private extension MXSample.MXFrame {
+    func toSentryFrame() -> Frame {
+        let frame = Frame()
+        frame.package = binaryName
+        frame.instructionAddress = sentry_formatHexAddressUInt64Swift(address)
+        frame.imageAddress = sentry_formatHexAddressUInt64Swift(address - UInt64(offsetIntoBinaryTextSegment))
+        return frame
+    }
+}
+
+private extension Sequence {
     func unique<T: Hashable>(by key: (Element) -> T) -> [Element] {
         var seen = Set<T>()
-        var result: [Element] = []
-        for element in self {
-            let k = key(element)
-            if !seen.contains(k) {
-                seen.insert(k)
-                result.append(element)
-            }
-        }
-
-        return result
+        return filter { seen.insert(key($0)).inserted }
     }
 }
 
-extension Dictionary where Value == Int {
+private extension Dictionary where Value == Int {
     func mostSampled() -> Key? {
         var mostSamples = -1
         var mostSampledKey: Key?