Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Nov 29, 2025

Convert this simple integration to Swift

#skip-changelog

Closes #6933

@noahsmartin noahsmartin added the ready-to-merge Use this label to trigger all PR workflows label Nov 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.78 ms 1260.53 ms 16.75 ms
Size 24.14 KiB 1.01 MiB 1013.52 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
55f739c 1226.06 ms 1248.78 ms 22.71 ms
018037b 1209.31 ms 1228.33 ms 19.03 ms
b709887 1193.52 ms 1216.74 ms 23.22 ms
3a3d93b 1220.07 ms 1257.89 ms 37.82 ms
62f8d2a 1226.24 ms 1249.92 ms 23.67 ms
0f410ad 1193.34 ms 1255.49 ms 62.15 ms
18be519 1241.22 ms 1260.57 ms 19.35 ms
8f2120f 1235.92 ms 1249.67 ms 13.75 ms
70ac6c6 1215.53 ms 1258.80 ms 43.27 ms
c174e5e 1209.65 ms 1238.73 ms 29.08 ms

App size

Revision Plain With Sentry Diff
55f739c 23.75 KiB 858.73 KiB 834.98 KiB
018037b 23.75 KiB 867.16 KiB 843.41 KiB
b709887 23.75 KiB 1.01 MiB 1016.14 KiB
3a3d93b 23.75 KiB 1022.78 KiB 999.04 KiB
62f8d2a 23.75 KiB 926.80 KiB 903.05 KiB
0f410ad 24.14 KiB 1.01 MiB 1014.82 KiB
18be519 23.75 KiB 926.64 KiB 902.90 KiB
8f2120f 23.75 KiB 941.78 KiB 918.03 KiB
70ac6c6 24.14 KiB 1.01 MiB 1012.77 KiB
c174e5e 23.75 KiB 953.92 KiB 930.16 KiB

Previous results on branch: swiftAsyncIntegrationSwift

Startup times

Revision Plain With Sentry Diff
e92c169 1222.38 ms 1256.91 ms 34.53 ms
46b8841 1222.51 ms 1250.14 ms 27.63 ms
a3f85ea 1214.82 ms 1248.58 ms 33.76 ms
05e34b3 1217.47 ms 1253.78 ms 36.31 ms
7ba76d4 1215.78 ms 1250.22 ms 34.44 ms

App size

Revision Plain With Sentry Diff
e92c169 24.14 KiB 1.01 MiB 1013.10 KiB
46b8841 24.14 KiB 1.02 MiB 1015.89 KiB
a3f85ea 24.14 KiB 1.02 MiB 1015.88 KiB
05e34b3 24.14 KiB 1.02 MiB 1015.88 KiB
7ba76d4 24.14 KiB 1.01 MiB 1014.43 KiB

@noahsmartin noahsmartin force-pushed the swiftAsyncIntegrationSwift branch 3 times, most recently from ce09a6f to f2d54a0 Compare November 29, 2025 17:04
@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.045%. Comparing base (af848c4) to head (6c65824).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6932       +/-   ##
=============================================
- Coverage   86.080%   85.045%   -1.036%     
=============================================
  Files          453       453               
  Lines        37617     27664     -9953     
  Branches     17497     12153     -5344     
=============================================
- Hits         32381     23527     -8854     
+ Misses        5189      4094     -1095     
+ Partials        47        43        -4     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySDKInternal.m 85.080% <100.000%> (-0.310%) ⬇️
Sources/Swift/Core/Integrations/Integrations.swift 100.000% <100.000%> (+10.526%) ⬆️
...ces/Swift/Integrations/SwiftAsyncIntegration.swift 100.000% <100.000%> (ø)

... and 412 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af848c4...6c65824. Read the comment docs.

@noahsmartin noahsmartin force-pushed the swiftAsyncIntegrationSwift branch from f2d54a0 to 86a60e4 Compare November 30, 2025 02:26
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

This reverts commit 132afbf.
@noahsmartin noahsmartin merged commit 98e0ee8 into main Dec 1, 2025
190 of 192 checks passed
@noahsmartin noahsmartin deleted the swiftAsyncIntegrationSwift branch December 1, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Convert SentrySwiftAsyncIntegration to Swift

3 participants