Rework agents modules configuration page (#840)

* Rework agents modules configuration page

Make more simple,
Switch to Twig

* Nolabel

* CS

* Update changelog

* Fix agent tab part; add tests

* CS

* Fix test

* minor UI fix

* minor UI fix: force small width for two first column

---------

Co-authored-by: Stanislas Kita <[email protected]>

Author: trasher

CHANGELOG.md

@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [1.6.4] - UNRELEASED
 
+- Rework the whole agents module configuration page
 - Fix URL for ressource (ajax/ front/ pics/ etc .. )
 - Fix several wrong URLs (still using PHP_SELF)
 

front/agentmodule.form.php

@@ -31,7 +31,6 @@
  * ---------------------------------------------------------------------
  */
 
-
 Html::header(
     __('GLPI Inventory', 'glpiinventory'),
     '',
@@ -44,88 +43,12 @@
 
 $agentmodule = new PluginGlpiinventoryAgentmodule();
 
-if (isset($_POST["agent_add"])) {
-    $agentmodule->getFromDB($_POST['id']);
-    $a_agentList         = importArrayFromDB($agentmodule->fields['exceptions']);
-    $a_agentList[]       = $_POST['agent_to_add'][0];
-    $input               = [];
-    $input['exceptions'] = exportArrayToDB($a_agentList);
-    $input['id']         = $_POST['id'];
-    $agentmodule->update($input);
-    Html::back();
-} elseif (isset($_POST["agent_delete"])) {
-    $agentmodule->getFromDB($_POST['id']);
-    $a_agentList         = importArrayFromDB($agentmodule->fields['exceptions']);
-    foreach ($a_agentList as $key => $value) {
-        if ($value == $_POST['agent_to_delete'][0]) {
-            unset($a_agentList[$key]);
-        }
-    }
-    $input = [];
-    $input['exceptions'] = exportArrayToDB($a_agentList);
-    $input['id'] = $_POST['id'];
-    $agentmodule->update($input);
+if (isset($_POST["update"])) {
+    $agentmodule->updateModules($_POST);
     Html::back();
-} elseif (isset($_POST["updateexceptions"])) {
-    $a_modules = $agentmodule->find();
-    foreach ($a_modules as $data) {
-        $a_agentList        = importArrayFromDB($data['exceptions']);
-        $agentModule        = 0;
-        if (
-            isset($_POST['activation-' . $data['modulename']])
-            && $_POST['activation-' . $data['modulename']] != 0
-        ) {
-            $agentModule     = 1;
-        }
-        $agentModuleBase    = 0;
-        if (in_array($_POST['id'], $a_agentList)) {
-            $agentModuleBase = 1;
-        }
-        if ($data['is_active'] == 0) {
-            if ($agentModule == 1 && $agentModuleBase == 0) {
-                $a_agentList[] = $_POST['id'];
-            } elseif ($agentModule == 0 && $agentModuleBase == 1) {
-                foreach ($a_agentList as $key => $value) {
-                    if ($value == $_POST['id']) {
-                        unset($a_agentList[$key]);
-                    }
-                }
-            }
-        } elseif ($data['is_active'] == 1) {
-            if ($agentModule == 1 && $agentModuleBase == 1) {
-                foreach ($a_agentList as $key => $value) {
-                    if ($value == $_POST['id']) {
-                        unset($a_agentList[$key]);
-                    }
-                }
-            } elseif ($agentModule == 0 && $agentModuleBase == 0) {
-                $a_agentList[]  = $_POST['id'];
-            }
-        }
-        $data['exceptions'] = exportArrayToDB($a_agentList);
-        $agentmodule->update($data);
-    }
-
-    Html::back();
-} elseif (isset($_POST["update"])) {
-    $agentmodule->getFromDB($_POST['id']);
-    $input = [];
-    if (
-        isset($_POST['activation'])
-        && $_POST['activation']
-    ) {
-        $input['is_active'] = 1;
-    } else {
-        $input['is_active'] = 0;
-    }
-    if ($agentmodule->fields['is_active'] != $input['is_active']) {
-        $a_agentList         = [];
-        $input['exceptions'] = exportArrayToDB($a_agentList);
-    }
-    $input['id']  = $_POST['id'];
-
-    $agentmodule->update($input);
+} elseif (isset($_POST["update_exceptions"])) {
+    $agentmodule->updateForAgent($_POST);
     Html::back();
 }
 
-Html::footer();
+return;