Skip to content

Commit be624d0

Browse files
authored
fix(contrib/opensergo): incorrect conversion between integer types (#3309)
* fix(contrib/opensergo): incorrect conversion between integer types * remove nolint * remove blank line
1 parent a803e9d commit be624d0

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

contrib/opensergo/opensergo.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,14 @@ func (s *OpenSergo) ReportMetadata(ctx context.Context, app kratos.AppInfo) erro
9797
if err != nil {
9898
return err
9999
}
100-
portValue, err := strconv.Atoi(port)
100+
portUint64, err := strconv.ParseUint(port, 10, 32)
101101
if err != nil {
102102
return err
103103
}
104104
serviceMetadata.Protocols = append(serviceMetadata.Protocols, u.Scheme)
105105
serviceMetadata.ListeningAddresses = append(serviceMetadata.ListeningAddresses, &v1.SocketAddress{
106106
Address: host,
107-
PortValue: uint32(portValue),
107+
PortValue: uint32(portUint64),
108108
})
109109
}
110110
_, err = s.mdClient.ReportMetadata(ctx, &v1.ReportMetadataRequest{

contrib/polaris/router.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ func (p *Polaris) NodeFilter(opts ...RouterOption) selector.NodeFilter {
8383
}
8484

8585
n := make(map[string]selector.Node, len(nodes))
86-
8786
for _, node := range nodes {
8887
n[node.Address()] = node
8988
}
@@ -112,10 +111,12 @@ func buildPolarisInstance(namespace string, nodes []selector.Node) *pb.ServiceIn
112111
for _, node := range nodes {
113112
host, port, err := net.SplitHostPort(node.Address())
114113
if err != nil {
114+
log.Errorf("split host port failed error: %v", err)
115115
return nil
116116
}
117-
portUint64, err := strconv.ParseUint(port, 10, 32) //nolint:gomnd
117+
portUint64, err := strconv.ParseUint(port, 10, 32)
118118
if err != nil {
119+
log.Errorf("parse port failed error: %v", err)
119120
return nil
120121
}
121122
ins = append(ins, &v1.Instance{

0 commit comments

Comments
 (0)