diff --git a/base/cvd/cuttlefish/host/commands/cvd/cli/commands/start.cpp b/base/cvd/cuttlefish/host/commands/cvd/cli/commands/start.cpp index c2dfe981b84..e54f03f82bd 100644 --- a/base/cvd/cuttlefish/host/commands/cvd/cli/commands/start.cpp +++ b/base/cvd/cuttlefish/host/commands/cvd/cli/commands/start.cpp @@ -58,7 +58,6 @@ #include "cuttlefish/host/commands/cvd/instances/instance_group_record.h" #include "cuttlefish/host/commands/cvd/instances/instance_manager.h" #include "cuttlefish/host/commands/cvd/instances/lock/instance_lock.h" -#include "cuttlefish/host/commands/cvd/instances/lock/lock_file.h" #include "cuttlefish/host/commands/cvd/instances/operator_client.h" #include "cuttlefish/host/commands/cvd/instances/reset_client_utils.h" #include "cuttlefish/host/commands/cvd/utils/common.h" @@ -299,9 +298,9 @@ class CvdStartCommandHandler : public CvdCommandHandler { Result CvdStartCommandHandler::AcloudCompatActions( const LocalInstanceGroup& group, const cvd_common::Envs& envs, const CommandRequest& request) { - // rm -fr "TempDir()/acloud_cvd_temp/local-instance-" + // rm -fr "InstanceLocksPath()/local-instance-" std::string acloud_compat_home_prefix = - TempDir() + "/acloud_cvd_temp/local-instance-"; + InstanceLocksPath() + "/local-instance-"; std::vector acloud_compat_homes; acloud_compat_homes.reserve(group.Instances().size()); for (const auto& instance : group.Instances()) { diff --git a/base/cvd/cuttlefish/host/commands/cvd/instances/lock/BUILD.bazel b/base/cvd/cuttlefish/host/commands/cvd/instances/lock/BUILD.bazel index 7c408b0a240..588f0a09623 100644 --- a/base/cvd/cuttlefish/host/commands/cvd/instances/lock/BUILD.bazel +++ b/base/cvd/cuttlefish/host/commands/cvd/instances/lock/BUILD.bazel @@ -22,6 +22,7 @@ cf_cc_library( "//cuttlefish/common/libs/utils:environment", "//cuttlefish/common/libs/utils:files", "//cuttlefish/common/libs/utils:result", + "//cuttlefish/host/commands/cvd/utils:common", "//libbase", ], ) diff --git a/base/cvd/cuttlefish/host/commands/cvd/instances/lock/instance_lock.cpp b/base/cvd/cuttlefish/host/commands/cvd/instances/lock/instance_lock.cpp index e09928d24a0..0ce91e9e7cd 100644 --- a/base/cvd/cuttlefish/host/commands/cvd/instances/lock/instance_lock.cpp +++ b/base/cvd/cuttlefish/host/commands/cvd/instances/lock/instance_lock.cpp @@ -37,6 +37,7 @@ #include "cuttlefish/common/libs/utils/contains.h" #include "cuttlefish/common/libs/utils/files.h" #include "cuttlefish/common/libs/utils/result.h" +#include "cuttlefish/host/commands/cvd/utils/common.h" namespace cuttlefish { @@ -66,7 +67,7 @@ InstanceLockFileManager::InstanceLockFileManager() {} Result InstanceLockFileManager::LockFilePath(int instance_num) { std::stringstream path; - path << TempDir() << "/acloud_cvd_temp/"; + path << InstanceLocksPath(); CF_EXPECT(EnsureDirectoryExists(path.str())); path << "local-instance-" << instance_num << ".lock"; return path.str(); diff --git a/base/cvd/cuttlefish/host/commands/cvd/instances/reset_client_utils.cpp b/base/cvd/cuttlefish/host/commands/cvd/instances/reset_client_utils.cpp index 32b20f283d7..98fb8bc1413 100644 --- a/base/cvd/cuttlefish/host/commands/cvd/instances/reset_client_utils.cpp +++ b/base/cvd/cuttlefish/host/commands/cvd/instances/reset_client_utils.cpp @@ -155,7 +155,7 @@ Result SendSignal(const GroupProcInfo& group_info) { } Result DeleteLockFile(const GroupProcInfo& group_info) { - const std::string lock_dir = "/tmp/acloud_cvd_temp"; + const std::string lock_dir = InstanceLocksPath(); std::string lock_file_prefix = lock_dir; lock_file_prefix.append("/local-instance-"); diff --git a/base/cvd/cuttlefish/host/commands/cvd/utils/common.cpp b/base/cvd/cuttlefish/host/commands/cvd/utils/common.cpp index 87b02daec91..0d9a64088c6 100644 --- a/base/cvd/cuttlefish/host/commands/cvd/utils/common.cpp +++ b/base/cvd/cuttlefish/host/commands/cvd/utils/common.cpp @@ -146,6 +146,10 @@ std::string InstanceDatabasePath() { return fmt::format("{}/instance_database.binpb", PerUserDir()); } +std::string InstanceLocksPath() { + return "/tmp/acloud_cvd_temp/"; +} + std::string DefaultBaseDir() { auto time = std::chrono::system_clock::now().time_since_epoch().count(); return fmt::format("{}/{}", PerUserDir(), time); diff --git a/base/cvd/cuttlefish/host/commands/cvd/utils/common.h b/base/cvd/cuttlefish/host/commands/cvd/utils/common.h index 5a6f21f77dc..4f2ce6d70ab 100644 --- a/base/cvd/cuttlefish/host/commands/cvd/utils/common.h +++ b/base/cvd/cuttlefish/host/commands/cvd/utils/common.h @@ -83,6 +83,8 @@ std::string PerUserCacheDir(); std::string InstanceDatabasePath(); +std::string InstanceLocksPath(); + std::string DefaultBaseDir(); Result GroupDirFromHome(std::string_view group_home_dir);