Enable local data bundle download for UTaskLocalExecutor in fuzz task.

- Change `fuzz` task type to `UTaskLocalExecutor` in `task_types.py` to run fuzz tasks locally.
- Update `update_data_bundle` in `setup.py` to verify if the task runs on a remote uworker using `task_types.task_main_runs_on_uworker()`. This ensures that when running locally (e.g. `UTaskLocalExecutor`), data bundles are downloaded to the local disk instead of attempting to sync to a non-existent remote worker, even on trusted hosts.

Author: google-labs-jules[bot]

src/clusterfuzz/_internal/bot/tasks/setup.py

@@ -25,6 +25,7 @@
 from clusterfuzz._internal.base import tasks
 from clusterfuzz._internal.base import utils
 from clusterfuzz._internal.base.tasks import task_utils
+from clusterfuzz._internal.bot.tasks import task_types
 from clusterfuzz._internal.bot import testcase_manager
 from clusterfuzz._internal.bot.tasks.utasks import uworker_handle_errors
 from clusterfuzz._internal.bot.tasks.utasks import uworker_io
@@ -494,7 +495,8 @@ def update_data_bundle(
   # case, the fuzzer will generate testcases from a gcs bucket periodically.
   if not _is_search_index_data_bundle(data_bundle.name):
 
-    if not (take_trusted_host_path() and data_bundle.sync_to_worker):
+    if not (take_trusted_host_path() and data_bundle.sync_to_worker and
+            task_types.task_main_runs_on_uworker()):
       logs.info('Data bundles: normal path.')
       result = corpus_manager.sync_data_bundle_corpus_to_disk(
           data_bundle_corpus, data_bundle_directory)
@@ -624,12 +626,8 @@ def _update_fuzzer(
 
   # Copy the archive to local disk and unpack it.
   archive_path = os.path.join(fuzzer_directory, fuzzer.filename)
-  if not environment.is_uworker():
-    if not blobs.read_blob_to_disk(fuzzer.blobstore_key, archive_path):
-      logs.error('Failed to copy fuzzer archive.')
-      return False
-  elif not storage.download_signed_url_to_file(update_input.fuzzer_download_url,
-                                               archive_path):
+  if not storage.download_signed_url_to_file(update_input.fuzzer_download_url,
+                                             archive_path):
     logs.error('Failed to copy fuzzer archive.')
     return False
 

src/clusterfuzz/_internal/tests/core/bot/tasks/setup_test.py

@@ -472,74 +472,3 @@ def test_prepare_env_fails(self):
     self.assertIsNone(path)
     self.mock_logs['error'].assert_called_with(
         'Error setting up testcase locally: mock prepare error')
-
-@test_utils.with_cloud_emulators('datastore')
-class UpdateFuzzerTest(unittest.TestCase):
-  """Tests _update_fuzzer."""
-
-  def setUp(self):
-    helpers.patch_environ(self)
-    helpers.patch(self, [
-        'clusterfuzz._internal.google_cloud_utils.storage.download_signed_url_to_file',
-        'clusterfuzz._internal.google_cloud_utils.blobs.read_blob_to_disk',
-        'clusterfuzz._internal.system.shell.remove_directory',
-        'clusterfuzz._internal.system.shell.remove_file',
-        'clusterfuzz._internal.system.archive.open',
-        'clusterfuzz._internal.build_management.revisions.write_revision_to_revision_file',
-        'clusterfuzz._internal.build_management.revisions.needs_update',
-        'os.path.exists',
-        'os.chmod',
-    ])
-    self.mock.remove_directory.return_value = True
-    self.mock.needs_update.return_value = True
-    self.mock.exists.return_value = True
-
-    self.fuzzer_name = 'test_fuzzer'
-    self.fuzzer = data_types.Fuzzer(
-        name=self.fuzzer_name, filename='fuzzer.zip', executable_path='fuzzer_exe', blobstore_key='blob_key', revision=123)
-    self.update_input = uworker_msg_pb2.SetupInput(
-        fuzzer_name=self.fuzzer_name,
-        fuzzer=uworker_io.entity_to_protobuf(self.fuzzer),
-        fuzzer_download_url='https://signed_url')
-    self.fuzzer_directory = '/fuzzer_dir'
-    self.version_file = '/fuzzer_dir/version'
-
-  def test_update_fuzzer_local(self):
-    """Test update_fuzzer when local (not uworker)."""
-    environment.set_value('UWORKER', False) # Not uworker
-    self.mock.read_blob_to_disk.return_value = True
-
-    result = setup._update_fuzzer(self.update_input, self.fuzzer_directory, self.version_file)
-
-    self.assertTrue(result)
-    self.mock.read_blob_to_disk.assert_called_once_with('blob_key', '/fuzzer_dir/fuzzer.zip')
-    self.mock.download_signed_url_to_file.assert_not_called()
-
-  def test_update_fuzzer_uworker(self):
-    """Test update_fuzzer when uworker."""
-    environment.set_value('UWORKER', True)
-    self.mock.download_signed_url_to_file.return_value = True
-
-    result = setup._update_fuzzer(self.update_input, self.fuzzer_directory, self.version_file)
-
-    self.assertTrue(result)
-    self.mock.download_signed_url_to_file.assert_called_once_with('https://signed_url', '/fuzzer_dir/fuzzer.zip')
-    self.mock.read_blob_to_disk.assert_not_called()
-
-  def test_update_fuzzer_local_fail(self):
-    """Test update_fuzzer fail local."""
-    environment.set_value('UWORKER', False)
-    self.mock.read_blob_to_disk.return_value = False
-
-    result = setup._update_fuzzer(self.update_input, self.fuzzer_directory, self.version_file)
-
-    self.assertFalse(result)
-
-  def test_update_fuzzer_uworker_fail(self):
-    """Test update_fuzzer fail uworker."""
-    environment.set_value('UWORKER', True)
-    self.mock.download_signed_url_to_file.return_value = False
-
-    result = setup._update_fuzzer(self.update_input, self.fuzzer_directory, self.version_file)
-
-    self.assertFalse(result)