Confusing naming

[kylewin]

Hello,

I find it a bit confusing with the name of the recording rules:

record: job:error_budget:slo
record: job:error_budget:remaining

As per srebook "An error budget is 1 minus the SLO of the service". So I'm not sure "error_budget:slo" is "error_budget" or "slo" or "slo of error budget". If I'm following the expr '(1 - 0.05) * 100', I'm assuming that your SLO is 95% and Error budget is 5% ?

So, if we're following the book, should the name be job:availability:slo ? (and let's understand job:availability:error_budget 5% implicitly.

Same thing to job:error_budget:remaining. From this name, I can understand that if Error budget is 5%, to assume burn_rate is 1%, we'll have job:error_budget:remaining 4% ? But it will not be this value following the expr "(1 - job:slo_errors_per_request:ratio_rate28d) * 100". Should it be job:availability(or slo):remaining ?

[rellupuru]

@kyledakid I concur with your comment.Hope repository owner respond to your question.

I don't think (1 - job:slo_errors_per_request:ratio_rate28d) * 100 represents record: job:error_budget:remaining.

[kylewin]

Yessss, @rellupuru . I think in term of "job:error_budget:remaining", it should be:

(1 - (job:slo_errors_per_request:ratio_rate28d / job:availability:error_budget))