Skip to content

Handle timestampVal type in stats.py #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihirvala08 merged 4 commits into from
Feb 3, 2026
Merged

Handle timestampVal type in stats.py #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
467e23f
Handle timestampVal type in stats.py
jbfuzier Jan 23, 2026
e5a957b
chore: fixed tests
mihirvala08 Jan 29, 2026
2e393e9
feat: add timestampVal support in list values and remove redundant ti…
mihirvala08 Feb 2, 2026
3b11501
chore: fixed linting
mihirvala08 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/secops/chronicle/stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ def process_stats_results(stats: dict[str, Any]) -> dict[str, Any]:
values.append(float(val["doubleVal"]))
elif "stringVal" in val:
values.append(val["stringVal"])
elif "timestampVal" in val:
values.append(
datetime.fromisoformat(
val["timestampVal"].replace("Z", "+00:00")
)
)
else:
values.append(None)
# Handle list value cells (like those from array_distinct)
Expand All @@ -139,6 +145,12 @@ def process_stats_results(stats: dict[str, Any]) -> dict[str, Any]:
list_values.append(float(list_val["doubleVal"]))
elif "stringVal" in list_val:
list_values.append(list_val["stringVal"])
elif "timestampVal" in list_val:
list_values.append(
datetime.fromisoformat(
list_val["timestampVal"].replace("Z", "+00:00")
)
)
values.append(list_values)
else:
values.append(None)
Expand Down
87 changes: 87 additions & 0 deletions tests/chronicle/test_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,93 @@ def test_get_stats_array_distinct(self) -> None:
self.assertEqual(result["rows"][0]["array_col"], ["X1", "X2"])
self.assertEqual(result["rows"][1]["array_col"], ["Y1", "Y2"])

def test_get_stats_timestamp_values(self) -> None:
"""Test get_stats with timestampVal support."""
mock_response = mock.MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {
"stats": {
"results": [
{
"column": "timestamp_col",
"values": [
{"value": {"timestampVal": "2024-01-15T10:30:00Z"}},
{
"value": {
"timestampVal": "2024-01-15T11:45:30.123Z"
}
},
],
},
{
"column": "event_count",
"values": [
{"value": {"int64Val": "100"}},
{"value": {"int64Val": "200"}},
],
},
]
}
}
self.mock_session.get.return_value = mock_response

result = get_stats(
self.mock_client, "test query", self.start_time, self.end_time
)

self.assertEqual(result["total_rows"], 2)
self.assertEqual(result["columns"], ["timestamp_col", "event_count"])
self.assertEqual(len(result["rows"]), 2)
self.assertIsInstance(result["rows"][0]["timestamp_col"], datetime)
self.assertIsInstance(result["rows"][1]["timestamp_col"], datetime)
self.assertEqual(result["rows"][0]["event_count"], 100)
self.assertEqual(result["rows"][1]["event_count"], 200)

def test_get_stats_timestamp_in_list(self) -> None:
"""Test get_stats with timestampVal in list values."""
mock_response = mock.MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {
"stats": {
"results": [
{
"column": "timestamp_array",
"values": [
{
"list": {
"values": [
{
"timestampVal": (
"2024-01-15T10:00:00Z"
)
},
{
"timestampVal": (
"2024-01-15T11:00:00Z"
)
},
]
}
},
],
}
]
}
}
self.mock_session.get.return_value = mock_response

result = get_stats(
self.mock_client, "test query", self.start_time, self.end_time
)

self.assertEqual(result["total_rows"], 1)
self.assertEqual(result["columns"], ["timestamp_array"])
self.assertEqual(len(result["rows"]), 1)
self.assertIsInstance(result["rows"][0]["timestamp_array"], list)
self.assertEqual(len(result["rows"][0]["timestamp_array"]), 2)
self.assertIsInstance(result["rows"][0]["timestamp_array"][0], datetime)
self.assertIsInstance(result["rows"][0]["timestamp_array"][1], datetime)

def test_process_stats_results_empty(self) -> None:
"""Test processing empty stats results."""
empty_stats: Dict[str, Any] = {}
Expand Down
Loading