chore: failing tests fixes

Author: denis256

internal/component/component.go

@@ -8,13 +8,37 @@
 package component
 
 import (
+	"path/filepath"
 	"slices"
 	"sort"
 	"sync"
 
 	"github.com/gruntwork-io/terragrunt/internal/errors"
 )
 
+// resolvedPathMemo caches results of filepath.EvalSymlinks to reduce repeated system calls.
+var resolvedPathMemo sync.Map // map[string]string
+
+// resolvePath resolves symlinks in a path for consistent comparison across platforms.
+// On macOS, /var is a symlink to /private/var, so paths must be resolved.
+func resolvePath(path string) string {
+	if v, ok := resolvedPathMemo.Load(path); ok {
+		if s, ok := v.(string); ok {
+			return s
+		}
+	}
+
+	resolved, err := filepath.EvalSymlinks(path)
+	if err != nil {
+		resolvedPathMemo.Store(path, path)
+		return path
+	}
+
+	resolvedPathMemo.Store(path, resolved)
+
+	return resolved
+}
+
 // Kind is the type of Terragrunt component.
 type Kind string
 
@@ -236,12 +260,15 @@ func (tsc *ThreadSafeComponents) addComponent(c Component) (Component, bool) {
 }
 
 // FindByPath searches for a component by its path and returns it if found, otherwise returns nil.
+// Paths are resolved to handle symlinks consistently across platforms (e.g., macOS /var -> /private/var).
 func (tsc *ThreadSafeComponents) FindByPath(path string) Component {
 	tsc.mu.RLock()
 	defer tsc.mu.RUnlock()
 
+	resolvedSearchPath := resolvePath(path)
+
 	for _, c := range tsc.components {
-		if c.Path() == path {
+		if resolvePath(c.Path()) == resolvedSearchPath {
 			return c
 		}
 	}

internal/discovery/dependentdiscovery.go

@@ -339,7 +339,8 @@ func (dd *DependentDiscovery) DiscoverDependents(
 
 				candidate.AddDependency(c)
 
-				if dep == target.Path() {
+				// Use resolved paths for comparison to handle symlinks (e.g., macOS /var -> /private/var)
+				if resolvePath(dep) == resolvePath(target.Path()) {
 					dependsOnTarget = true
 				}
 			}

internal/discovery/discovery.go

@@ -1572,6 +1572,9 @@ func extractDependencyPaths(cfg *config.TerragruntConfig, component component.Co
 			depPath = filepath.Clean(filepath.Join(component.Path(), depPath))
 		}
 
+		// Resolve symlinks for consistent path comparison (e.g., macOS /var -> /private/var)
+		depPath = resolvePath(depPath)
+
 		deduped[depPath] = struct{}{}
 	}
 
@@ -1581,6 +1584,9 @@ func extractDependencyPaths(cfg *config.TerragruntConfig, component component.Co
 				dependency = filepath.Clean(filepath.Join(component.Path(), dependency))
 			}
 
+			// Resolve symlinks for consistent path comparison (e.g., macOS /var -> /private/var)
+			dependency = resolvePath(dependency)
+
 			deduped[dependency] = struct{}{}
 		}
 	}

test/fixtures/auth-provider-parallel/auth-provider.sh

@@ -13,12 +13,15 @@ mkdir -p "$LOCK_DIR"
 # This works on Linux, macOS, and BSD without requiring nanosecond precision
 INVOCATION_ID="auth-$$-$(date +%s)-$RANDOM"
 
-# Log to stderr so it shows up in terragrunt output
-echo "Auth start ${INVOCATION_ID}" >&2
-
 # Create a lock file to indicate we've started
+# This acts as a synchronization point - by the time the file is created,
+# the parent process should be ready to capture our stderr output.
 touch "${LOCK_DIR}/start-${INVOCATION_ID}"
 
+# Log to stderr so it shows up in terragrunt output
+# Note: Output after lock file creation to avoid macOS stderr buffering race condition
+echo "Auth start ${INVOCATION_ID}" >&2
+
 # Wait for other auth commands to also start (up to 500ms)
 # This ensures we test the parallel execution scenario
 WAIT_COUNT=0

test/integration_destroy_test.go

@@ -33,6 +33,9 @@ func TestTerragruntDestroyOrder(t *testing.T) {
 	helpers.CleanupTerraformFolder(t, testFixtureDestroyOrder)
 	tmpEnvPath := helpers.CopyEnvironment(t, testFixtureDestroyOrder)
 	rootPath := util.JoinPath(tmpEnvPath, testFixtureDestroyOrder, "app")
+	// Resolve symlinks to avoid path mismatches on macOS where /var -> /private/var
+	rootPath, err := filepath.EvalSymlinks(rootPath)
+	require.NoError(t, err)
 
 	helpers.RunTerragrunt(t, "terragrunt run --all apply --non-interactive --working-dir "+rootPath)
 
@@ -47,6 +50,9 @@ func TestTerragruntApplyDestroyOrder(t *testing.T) {
 	helpers.CleanupTerraformFolder(t, testFixtureDestroyOrder)
 	tmpEnvPath := helpers.CopyEnvironment(t, testFixtureDestroyOrder)
 	rootPath := util.JoinPath(tmpEnvPath, testFixtureDestroyOrder, "app")
+	// Resolve symlinks to avoid path mismatches on macOS where /var -> /private/var
+	rootPath, err := filepath.EvalSymlinks(rootPath)
+	require.NoError(t, err)
 
 	helpers.RunTerragrunt(t, "terragrunt run --all apply --non-interactive --working-dir "+rootPath)
 
@@ -72,6 +78,9 @@ func TestTerragruntDestroyOrderWithQueueIgnoreErrors(t *testing.T) {
 	helpers.CleanupTerraformFolder(t, testFixtureDestroyOrder)
 	tmpEnvPath := helpers.CopyEnvironment(t, testFixtureDestroyOrder)
 	rootPath := util.JoinPath(tmpEnvPath, testFixtureDestroyOrder, "app")
+	// Resolve symlinks to avoid path mismatches on macOS where /var -> /private/var
+	rootPath, err := filepath.EvalSymlinks(rootPath)
+	require.NoError(t, err)
 
 	helpers.RunTerragrunt(t, "terragrunt run --all apply --non-interactive --working-dir "+rootPath)
 

test/integration_runner_pool_test.go

@@ -205,6 +205,9 @@ func TestAuthProviderParallelExecution(t *testing.T) {
 	helpers.CleanupTerraformFolder(t, testFixtureAuthProviderParallel)
 	tmpEnvPath := helpers.CopyEnvironment(t, testFixtureAuthProviderParallel)
 	testPath := util.JoinPath(tmpEnvPath, testFixtureAuthProviderParallel)
+	// Resolve symlinks to avoid path mismatches on macOS where /var -> /private/var
+	testPath, err := filepath.EvalSymlinks(testPath)
+	require.NoError(t, err)
 
 	authProviderScript := filepath.Join(testPath, "auth-provider.sh")