Skip to content

Conversation

@VH571
Copy link

@VH571 VH571 commented Dec 23, 2024

Developer: Victor Herrera

Closes #91

Pull Request Summary

Code Review

Pull Request Readiness Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Ask for a review in communication channels

Screenshots/Screencast

Screenshot 2024-12-22 231124

@elhagen13
Copy link

Hi! Right now I can't really review it on a local environment since your .env file with your MONGO_URI is in your .gitignore (good code practice, but also means I can't access your site). It also seems like your deployment https://bootcamp-project-2024-sigma.vercel.app, isn't working. Also, when you do deploy, remember to change all localhost references to your new deployed site.

@VH571
Copy link
Author

VH571 commented Dec 27, 2024

@elhagen13
Copy link

Checked it out locally, and everything looks great! It seems like there still might be a deployment issue though, because when I click on the link it says I don't have access because I'm not a team member. You might have to fiddle around with the settings to make sure it's public. I think you can probably check your url in incognito mode to make sure everything is working properly. Lmk if this is just a problem on my end!

@elhagen13
Copy link

Also it looks like you still have a reference to localhost on blog/[slug]/page.tsx which might mess things up on your deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Milestone 4

2 participants