Skip to content

Conversation

@BennyGaming635
Copy link
Contributor

[Adding] hackvault.hackclub.com

Description

This is for a YSWS sponsored by @claynicholson. We've gotten approval from him to publish this domain. Currently the site is bennygaming635.github.io/hackvault.

@BennyGaming635 BennyGaming635 requested review from a team as code owners November 11, 2025 06:10
Copy link
Member

@alx-alexpark alx-alexpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you didn't add the record for the actual site, look under the files changed tab to make sure your PR is exactly how you want it

@BennyGaming635
Copy link
Contributor Author

I think thats fixed

Copy link
Contributor Author

@BennyGaming635 BennyGaming635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member

@alx-alexpark alx-alexpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls sort in alpha order within the domains that start with "h"

@BennyGaming635
Copy link
Contributor Author

oops wrong button

@BennyGaming635
Copy link
Contributor Author

is this better??

@BennyGaming635
Copy link
Contributor Author

@alx-alexpark fixed it

@BennyGaming635
Copy link
Contributor Author

Who needs to approve to merge now?

@alx-alexpark
Copy link
Member

one of the checks is mega goofed for some reason i need to talk to my team about it, sorry for the delay

@BennyGaming635
Copy link
Contributor Author

alright

@alx-alexpark
Copy link
Member

Please update your branch to be up to date

@BennyGaming635
Copy link
Contributor Author

@alx-alexpark fixed again

@alx-alexpark
Copy link
Member

Can you update it again? new commits were pushed this morning so its out of date again

@BennyGaming635
Copy link
Contributor Author

yep done @alx-alexpark

@alx-alexpark alx-alexpark merged commit 8fe846b into hackclub:main Nov 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants