Skip to content

Commit 4ea9595

Browse files
committed
Fix build_callbacks close #1589
1 parent 5206714 commit 4ea9595

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

hanlp/common/component.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ def fit(self, trn_data, dev_data, save_dir, batch_size, epochs, run_eagerly=Fals
338338
self.save_meta(save_dir)
339339
trn_data = self.build_train_dataset(trn_data, batch_size, num_examples)
340340
dev_data = self.build_valid_dataset(dev_data, batch_size)
341-
callbacks = self.build_callbacks(save_dir, logger, **self.config)
341+
callbacks = self.build_callbacks(save_dir, **merge_dict(self.config, overwrite=True, logger=logger))
342342
# need to know #batches, otherwise progbar crashes
343343
dev_steps = math.ceil(size_of_dataset(dev_data) / batch_size)
344344
checkpoint = get_callback_by_class(callbacks, tf.keras.callbacks.ModelCheckpoint)

hanlp/components/parsers/biaffine_parser.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from hanlp.layers.embeddings import build_embedding
1111
from hanlp.metrics.parsing.labeled_f1 import LabeledF1
1212
from hanlp.metrics.parsing.labeled_score import LabeledScore
13-
from hanlp.utils.util import merge_locals_kwargs
13+
from hanlp.utils.util import merge_locals_kwargs, merge_dict
1414

1515

1616
class BiaffineDependencyParser(KerasComponent):
@@ -219,7 +219,9 @@ def build_train_dataset(self, trn_data, batch_size, num_examples):
219219

220220
# noinspection PyMethodOverriding
221221
def build_callbacks(self, save_dir, logger, metrics, **kwargs):
222-
callbacks = super().build_callbacks(save_dir, logger, metrics=metrics, **kwargs)
222+
callbacks = super().build_callbacks(save_dir,
223+
**merge_dict(self.config, overwrite=True, logger=logger, metrics=metrics,
224+
**kwargs))
223225
if isinstance(metrics, tuple):
224226
metrics = list(metrics)
225227
callbacks.append(self.build_progbar(metrics))

hanlp/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
# Author: hankcs
33
# Date: 2019-12-28 19:26
44

5-
__version__ = '2.0.0-alpha.67'
5+
__version__ = '2.0.0-alpha.68'

0 commit comments

Comments
 (0)