Translators / Translations Needed!

[hargata]

Made this discussion thread to make it easier to coordinate translation efforts, if you're interested in localizing LubeLogger, please read the following documentation:
https://docs.lubelogger.com/Translations

This thread is also where I will post updates regarding when new updates are released that will necessitate further translation.

The translation repository is located at: https://github.com/hargata/lubelog_translations

[hargata]

Currently we have a German translation that needs reviewed, I don't speak German, and would greatly appreciate it if someone could review it, thanks!

hargata/lubelog_translations#5

[rbnhln]

I've reviewed the german translation and want to make some change suggestions. How do I need to do that?

[hargata]

You can leave a comment on his pull request.

[hargata]

for now, since we don't have a German translation in the repo yet, once his changes are merged in, in the future, you can make changes to the translation by forking from the repo and then making a pull request.

[rbnhln]

Great, found a way to review with the suggestions.

[6asc]

I've just added a French translation, would be great if anyone is able to review it (this is my first translation so there are probably a few mistakes)
hargata/lubelog_translations#12

[nichwall]

Hey there! I just discovered LubeLogger and it's pretty nifty! I've helped out a lot with Audiobookshelf, and one of the things we have discussed a lot is managing translations.

Our basic workflow is that users make a copy of the English translation file (which is the source of truth for keys). Any new strings are added to the English source file and a script copies any new keys to the other languages. Contributors can then update translations of any strings they notice are out of date as new strings are added. We require the keys to be in alphabetical order so updates are easier to review.

I recently made an integration workflow that checks that the keys are in order as part of PRs/commits. I also have a workflow that will automatically run the "copy keys script", create a branch, and open a PR for the translations.

Would either of these workflows (or something similar if you can give me more specific instructions) be useful for y'all?

[ialfarol]

Hi @hargata, I'm no developer at all, but discovered this piece of software, and would like to implement this in my car repair shop. But, also want to collaborate with the Spanish translation.

Is there a chance to add/change currency support?

[acmg]

Hi.
I've just added a Spanish of Spain translation, feel free to review it: hargata/lubelog_translations#49
Thanks!!

[Sunsurfer89]

Moin from Germany,

@hargata while setting up Lubelogger on my NAS (Docker) and start filling data, I noticed that the translations of LubeLogger are not in place everywhere. For example, I discovered the file wwwroot/js/shared.js which is providing some popups/modals and all the titles and texts/html code is hardcoded and does not allow a proper translation.

1. Are there any plans to change the way how the texts are promoted, and is there a way to include placeholders there too, that find their way into the language JSON files?
   I guess that would make the app more robust and user-friendly.

While speaking about that:
2. Are there any ambitions to use translation services such as transifex or weblate (or similar things) to make the translation contribution in a more controlled manner?

Looking forward to your comments and plans. I would love to help where I can because Lubelogger shall become my master car recording tool. (I want to get rid of another paid Andorid app in favor of LubeLogger 😉)

[Sunsurfer89]

... and in addition: Is there a specific reason that the default language file wwwroot/defaults/en_US.json is a single line code file? Wouldn't it be better to have one line per key:value pair? Just for better read-ability and for easier usage as master file for other languages?

[hargata]

You're supposed to use the translation editor instead of editing it line by line: https://docs.lubelogger.com/Misc/Translations#creating-your-own-translation

Regarding the hardcoded texts in the popups, we plan to move away from the JS-based popups sometime next year because the JS popups are really hard to shimmy the translation layer

[Sunsurfer89]

Many thanks for your answer.

I'm aware of the Editor but the problem/burden, that I discovered, is the following:

Example:
The file main/Views/Vehicle/_ReportHeader.cshtml contains the string "Distance Traveled". Of course, this string pattern exists in the default language file wwwroot/defaults/en_US.json with key-value-pair: "Distance_Traveled":"Distance Traveled"
However, if we look for example into the lubelog_translations/blob/main/Europe/de.json translation, this key-value pair is not defined, so Lubelogger will do a fall-back to the default translation. Which is fine.

But what I'm trying to emphasize is the fact, that the language files are relatively quickly out of sync. To update/change translations, from my little perspective, there are a few steps necessary... which could be at least better controlled and finally maintained by the mentioned translation tools. I expect that this would be very beneficial for the tool reputation to have such a centralized translation setup.
And finally, no code is necessary for an own translation editor... 😉 Just my little opinion. 😇

Hope, I was able to show what I mean and where I see some room for improvement. But maybe there is a good reason to do it differently?!