Skip to content

Fix the simulator and recreate disabled publisher tests #1943

@jsync-swirlds

Description

@jsync-swirlds

Story Form

As a Block Node Manager
I want to have thorough testing for NodeBehindPublisher handling
So that I have confidence in system correctness

Technical Notes

The block node simulator has a flawed assumption; that "too far behind" is a send-in-a-new-connection message from the publisher; which was never what the protocol design allowed. This flawed assumption must be fixed so that the simulator supports sending too-far-behind as a message on the same connection that the publisher received a NodeBehindPublisher message.
Once the simulator is fixed, the E2E test suites that expect "behind" responses or try to initiate autonomous backfill need to be rewritten to properly test those scenarios. Any known gaps around node-behind handling should be more thoroughly tested as well.
The existing test scenarios that need to be rewritten are disabled currently; mostly in PositiveMultiplePublishersTests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    Status

    🧊 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions