Skip to content

Commit bc58bd4

Browse files
committed
Extract constant for number of siblings per block
Signed-off-by: Matt Hess <[email protected]>
1 parent b940f8f commit bc58bd4

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/BlockStreamManager.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
*/
3030
public interface BlockStreamManager extends BlockRecordInfo, StateHashedListener {
3131
Bytes ZERO_BLOCK_HASH = Bytes.wrap(new byte[48]);
32+
int NUM_SIBLINGS_PER_BLOCK = 4;
3233

3334
/**
3435
* The types of work that may be identified as pending within a block.

hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/FileBlockItemWriter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
package com.hedera.node.app.blocks.impl.streaming;
33

44
import static com.hedera.hapi.util.HapiUtils.asAccountString;
5+
import static com.hedera.node.app.blocks.BlockStreamManager.NUM_SIBLINGS_PER_BLOCK;
56
import static com.swirlds.common.io.utility.FileUtils.getAbsolutePath;
67
import static java.util.Objects.requireNonNull;
78

@@ -243,7 +244,7 @@ public static List<OnDiskPendingBlock> loadContiguousPendingBlocks(
243244
// Verify old proofs without block timestamp or sibling hashes are skipped
244245
if (pendingProof.blockTimestamp() == null
245246
|| Objects.equals(pendingProof.blockTimestamp(), Timestamp.DEFAULT)
246-
|| pendingProof.siblingHashesFromPrevBlockRoot().size() != 4) {
247+
|| pendingProof.siblingHashesFromPrevBlockRoot().size() != NUM_SIBLINGS_PER_BLOCK) {
247248
logger.warn(
248249
"Pending proof metadata from {} is missing required fields (not considering remaining - {})",
249250
proofJson.toPath(),

0 commit comments

Comments
 (0)