-
Notifications
You must be signed in to change notification settings - Fork 186
feat: Simple fees support for Token Create with custom fees #22275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22275 +/- ##
============================================
- Coverage 73.40% 73.40% -0.01%
+ Complexity 23545 23537 -8
============================================
Files 2574 2574
Lines 97201 97197 -4
Branches 10315 10314 -1
============================================
- Hits 71355 71347 -8
- Misses 22070 22072 +2
- Partials 3776 3778 +2
... and 18 files with indirect coverage changes 🚀 New features to boost your workflow:
|
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
Neeharika-Sompalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still relevant , considering this PR #21980
|
I will rebase once the previous PR is merged. Part of this PR won't be needed anymore, but I think it'll still be needed for the custom fees. |
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
add mint unique token test add Token model tests add mintCommonToken handler tests Signed-off-by: Josh Marinacci <[email protected]>
move token services simple fees tests to separate file Signed-off-by: Josh Marinacci <[email protected]>
create new compare() function to compare old and new versions of fees Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
switch token create and token mint to calculators update token extras fees Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
…reeze, token pause, token unpause Signed-off-by: Josh Marinacci <[email protected]>
remove unneeded code Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
305eadb to
5c7b60d
Compare
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
hapi/hedera-protobuf-java-api/src/main/proto/fees/fee_schedule.proto
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Show resolved
Hide resolved
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
Neeharika-Sompalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @joshmarinacci . Regarding token mint pricing for multiple nft mints, we can re-visit how to charge exactly.
Signed-off-by: Josh Marinacci <[email protected]>
Description:
Adds support for token create with custom fees. Removes FT vs NFT distinction for Token Create because the price is the same. The prices only differ for Token Mint.
Related issue(s):
Fixes # #21832
Notes for reviewer:
Checklist