-
Notifications
You must be signed in to change notification settings - Fork 186
chore: Refactors to prepare for adding the block node service client #22354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tim Farber-Newman <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Tim Farber-Newman <[email protected]>
Signed-off-by: Tim Farber-Newman <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #22354 +/- ##
=========================================
Coverage 71.00% 71.00%
- Complexity 24808 24822 +14
=========================================
Files 2718 2720 +2
Lines 105905 105930 +25
Branches 11171 11175 +4
=========================================
+ Hits 75201 75219 +18
- Misses 26618 26623 +5
- Partials 4086 4088 +2
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Farber-Newman <[email protected]>
Signed-off-by: Tim Farber-Newman <[email protected]>
Signed-off-by: Tim Farber-Newman <[email protected]>
Description:
This is part one of adding the block node service client to retrieve server status information from. The primary changes are moving some of the to-be common components out of
BlockNodeConnectionand into a new shared class:AbstractBlockNodeConnection. Eventually the existingBlockNodeConnectionwill be changed toBlockNodeStreamingConnectionand a newBlockNodeServiceConnectionwill be created for the service client.Related issue(s):
Fixes #21856
Notes for reviewer:
Checklist