Skip to content

Conversation

@aderevets
Copy link
Contributor

@aderevets aderevets commented Dec 1, 2025

Description:
Implement simple fees calculators for crypto services queries.

Related issue(s):

Fixes #20443

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@aderevets aderevets requested review from a team as code owners December 1, 2025 17:50
@aderevets aderevets self-assigned this Dec 1, 2025
@lfdt-bot
Copy link

lfdt-bot commented Dec 1, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@aderevets aderevets marked this pull request as draft December 1, 2025 18:13
Signed-off-by: artemderevets <[email protected]>
# Conflicts:
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
@aderevets aderevets marked this pull request as ready for review December 3, 2025 15:44
Signed-off-by: artemderevets <[email protected]>
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 62.12121% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...dera/node/app/workflows/query/QueryDispatcher.java 26.92% 17 Missing and 2 partials ⚠️
...hedera/node/app/spi/fees/ServiceFeeCalculator.java 33.33% 2 Missing ⚠️
...era/node/app/spi/fees/SimpleFeeCalculatorImpl.java 93.75% 0 Missing and 1 partial ⚠️
...ra/node/app/workflows/query/QueryWorkflowImpl.java 75.00% 1 Missing ⚠️
...lculator/CryptoGetAccountRecordsFeeCalculator.java 88.88% 1 Missing ⚠️
...en/impl/calculator/CryptoGetInfoFeeCalculator.java 87.50% 1 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #22368      +/-   ##
============================================
- Coverage     71.00%   70.99%   -0.02%     
- Complexity    24808    24822      +14     
============================================
  Files          2718     2720       +2     
  Lines        105905   105964      +59     
  Branches      11171    11176       +5     
============================================
+ Hits          75201    75228      +27     
- Misses        26618    26650      +32     
  Partials       4086     4086              
Files with missing lines Coverage Δ Complexity Δ
.../node/app/service/token/impl/TokenServiceImpl.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...era/node/app/spi/fees/SimpleFeeCalculatorImpl.java 89.13% <93.75%> (+6.77%) 14.00 <7.00> (+6.00)
...ra/node/app/workflows/query/QueryWorkflowImpl.java 83.96% <75.00%> (-4.41%) 17.00 <0.00> (ø)
...lculator/CryptoGetAccountRecordsFeeCalculator.java 88.88% <88.88%> (ø) 4.00 <4.00> (?)
...en/impl/calculator/CryptoGetInfoFeeCalculator.java 87.50% <87.50%> (ø) 4.00 <4.00> (?)
...hedera/node/app/spi/fees/ServiceFeeCalculator.java 83.33% <33.33%> (-16.67%) 5.00 <1.00> (+1.00) ⬇️
...dera/node/app/workflows/query/QueryDispatcher.java 65.45% <26.92%> (-34.55%) 29.00 <3.00> (+2.00) ⬇️

... and 14 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
@aderevets aderevets changed the title feat: Implement simple fees calculators for crypto services queries. feat: Simple fees calculators for crypto services queries Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crypto Service support

2 participants