Skip to content

Conversation

@lukelee-sl
Copy link
Contributor

Description:

Create a contract service interface that allows for the updating of the byte code for an EOA and use it from the token service.

Related issue(s):

Fixes #22409

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@lfdt-bot
Copy link

lfdt-bot commented Dec 4, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@lukelee-sl lukelee-sl marked this pull request as draft December 4, 2025 15:55
Signed-off-by: Luke Lee <[email protected]>
@lukelee-sl lukelee-sl self-assigned this Dec 4, 2025
@lukelee-sl lukelee-sl added this to the v0.70 milestone Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 32.69231% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...vice/contract/impl/ContractServiceApiProvider.java 4.76% 20 Missing ⚠️
...rvice/token/impl/handlers/CryptoCreateHandler.java 20.00% 2 Missing and 2 partials ⚠️
...rvice/token/impl/handlers/CryptoUpdateHandler.java 20.00% 2 Missing and 2 partials ⚠️
...ontract/impl/state/WritableContractStateStore.java 0.00% 3 Missing ⚠️
.../impl/exec/delegation/CodeDelegationProcessor.java 0.00% 1 Missing ⚠️
...act/impl/exec/delegation/CodeDelegationResult.java 50.00% 1 Missing ⚠️
...ract/impl/handlers/EthereumTransactionHandler.java 50.00% 0 Missing and 1 partial ⚠️
...ontract/impl/state/ReadableContractStateStore.java 0.00% 1 Missing ⚠️

Impacted file tree graph

@@                         Coverage Diff                          @@
##             feature/hedera-evm-pectra-support   #22429   +/-   ##
====================================================================
  Coverage                                     ?   70.84%           
  Complexity                                   ?    24497           
====================================================================
  Files                                        ?     2673           
  Lines                                        ?   104543           
  Branches                                     ?    11002           
====================================================================
  Hits                                         ?    74067           
  Misses                                       ?    26411           
  Partials                                     ?     4065           
Files with missing lines Coverage Δ Complexity Δ
.../hedera/node/app/workflows/FacilityInitModule.java 27.27% <100.00%> (ø) 5.00 <0.00> (?)
...ows/standalone/impl/StandaloneDispatchFactory.java 95.58% <100.00%> (ø) 5.00 <1.00> (?)
...app/service/contract/impl/ContractServiceImpl.java 97.05% <100.00%> (ø) 8.00 <1.00> (?)
...ontract/impl/exec/gas/HederaGasCalculatorImpl.java 96.55% <100.00%> (ø) 11.00 <1.00> (?)
...era/node/app/service/contract/ContractService.java 66.66% <ø> (ø) 2.00 <0.00> (?)
.../impl/exec/delegation/CodeDelegationProcessor.java 83.92% <0.00%> (ø) 20.00 <0.00> (?)
...act/impl/exec/delegation/CodeDelegationResult.java 88.88% <50.00%> (ø) 4.00 <1.00> (?)
...ract/impl/handlers/EthereumTransactionHandler.java 78.88% <50.00%> (ø) 15.00 <0.00> (?)
...ontract/impl/state/ReadableContractStateStore.java 88.23% <0.00%> (ø) 10.00 <0.00> (?)
...ontract/impl/state/WritableContractStateStore.java 86.36% <0.00%> (ø) 9.00 <0.00> (?)
... and 3 more

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Dec 4, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 74bc9fb1 42.31%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (74bc9fb) Report Missing Report Missing Report Missing
Head commit (067f6be) 104448 78088 74.76%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#22429) 52 22 42.31%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants