Remove network fees related js code from the rest module (#12568)

 Remove network fees js endpoint code from the rest module, since we now have the rest-java equivalent.

---------

Signed-off-by: sdimitrov9 <[email protected]>

Author: sdimitrov9

charts/hedera-mirror-rest-java/values.yaml

@@ -81,11 +81,9 @@ gateway:
         - path:
             type: RegularExpression
             value: '/api/v1/network/exchangerate'
-        {{- if .Values.routes.fees }}
         - path:
             type: RegularExpression
             value: '/api/v1/network/fees$'
-        {{- end }}
         - path:
             type: RegularExpression
             value: '/api/v1/network/stake$'
@@ -145,7 +143,6 @@ ingress:
         - path: '/api/v1/accounts/(\d+\.){0,2}(\d+|(0x)?[A-Fa-f0-9]{40}|(?:[A-Z2-7]{8})*(?:[A-Z2-7]{2}|[A-Z2-7]{4,5}|[A-Z2-7]{7,8}))/hooks/(0|[1-9]\d*)/storage'
         - path: '/api/v1/network/exchangerate'
         - path: '/api/v1/network/fees$'
-          condition: "{{ .Values.routes.fees }}"
         - path: '/api/v1/network/stake$'
         - path: '/api/v1/network/supply$'
           condition: "{{ .Values.routes.supply }}"
@@ -330,7 +327,6 @@ resources:
 revisionHistoryLimit: 3
 
 routes:
-  fees: true
   supply: false
 
 securityContext:

rest/__tests__/controllers/networkController.test.js

@@ -2,7 +2,6 @@
 
 import * as constants from '../../constants';
 import {NetworkController} from '../../controllers';
-import {FileData} from '../../model';
 import networkCtrl from '../../controllers/networkController';
 import * as utils from '../../utils';
 import EntityId from '../../entityId.js';
@@ -165,125 +164,6 @@ describe('validateExtractNetworkNodesQuery throw', () => {
   });
 });
 
-describe('extractFileDataQuery', () => {
-  const defaultExpected = {
-    filterQuery: {
-      whereQuery: [],
-    },
-    order: constants.orderFilterValues.ASC,
-  };
-
-  const specs = [
-    {
-      name: 'no timestamp',
-      input: {
-        filters: [],
-      },
-      expected: {
-        ...defaultExpected,
-      },
-    },
-    {
-      name: 'le timestamp',
-      input: {
-        filters: [
-          {
-            key: constants.filterKeys.TIMESTAMP,
-            operator: utils.opsMap.lt,
-            value: 2,
-          },
-        ],
-      },
-      expected: {
-        ...defaultExpected,
-        filterQuery: {
-          whereQuery: [
-            {
-              query: `${FileData.CONSENSUS_TIMESTAMP}  < `,
-              param: 2,
-            },
-          ],
-        },
-      },
-    },
-    {
-      name: 'lte timestamp',
-      input: {
-        filters: [
-          {
-            key: constants.filterKeys.TIMESTAMP,
-            operator: utils.opsMap.lte,
-            value: 2,
-          },
-        ],
-      },
-      expected: {
-        ...defaultExpected,
-        filterQuery: {
-          whereQuery: [
-            {
-              query: `${FileData.CONSENSUS_TIMESTAMP}  <= `,
-              param: 2,
-            },
-          ],
-        },
-      },
-    },
-    {
-      name: 'gt timestamp',
-      input: {
-        filters: [
-          {
-            key: constants.filterKeys.TIMESTAMP,
-            operator: utils.opsMap.gt,
-            value: 2,
-          },
-        ],
-      },
-      expected: {
-        ...defaultExpected,
-        filterQuery: {
-          whereQuery: [
-            {
-              query: `${FileData.CONSENSUS_TIMESTAMP}  > `,
-              param: 2,
-            },
-          ],
-        },
-      },
-    },
-    {
-      name: 'gte timestamp',
-      input: {
-        filters: [
-          {
-            key: constants.filterKeys.TIMESTAMP,
-            operator: utils.opsMap.gte,
-            value: 2,
-          },
-        ],
-      },
-      expected: {
-        ...defaultExpected,
-        filterQuery: {
-          whereQuery: [
-            {
-              query: `${FileData.CONSENSUS_TIMESTAMP}  >= `,
-              param: 2,
-            },
-          ],
-        },
-      },
-    },
-  ];
-
-  specs.forEach((spec) => {
-    test(`${spec.name}`, () => {
-      expect(networkCtrl.extractFileDataQuery(spec.input.filters)).toEqual(spec.expected);
-    });
-  });
-});
-
 describe('convertToCurrencyFormat', () => {
   it.each`
     tinycoins                | currencyFormat | expected

rest/__tests__/model/feeSchedule.test.js

@@ -97,10 +97,6 @@ describe('System Entities', () => {
     expect(EntityId.systemEntity.exchangeRateFile.toString()).toEqual('1.2.112');
   });
 
-  test('feeScheduleFile', () => {
-    expect(EntityId.systemEntity.feeScheduleFile.toString()).toEqual('1.2.111');
-  });
-
   test('stakingRewardAccount', () => {
     expect(EntityId.systemEntity.stakingRewardAccount.toString()).toEqual('1.2.800');
   });

rest/__tests__/non-zero-shard-realm.test.js

@@ -117,98 +117,3 @@ describe('FileDataService.getLatestFileDataContents tests', () => {
     );
   });
 });
-
-const feeScheduleFiles = [
-  {
-    consensus_timestamp: 1,
-    entity_id: 111,
-    file_data: Buffer.from('0a280a0a08541a061a0440a8953a0a0a08061a061a0440a8aa330a0a', 'hex'),
-    transaction_type: 17,
-  },
-  {
-    consensus_timestamp: 2,
-    entity_id: 111,
-    file_data: Buffer.from('08071a061a0440c0843d120208011200', 'hex'),
-    transaction_type: 16,
-  },
-  {
-    consensus_timestamp: 3,
-    entity_id: 111,
-    file_data: Buffer.from('0a220a0808541a041a0240150a0808061a041a0240010a0808071a041a02400112020801', 'hex'),
-    transaction_type: 19,
-  },
-  {
-    consensus_timestamp: 4,
-    entity_id: 111,
-    file_data: Buffer.from(
-      '0a280a0a08541a061a04408888340a0a08061a061a0440889d2d0a0a08071a061a0440b0b63c120208011200',
-      'hex'
-    ),
-    transaction_type: 19,
-  },
-];
-
-const expectedFeeSchedulePreviousFile = {
-  timestamp: 2,
-  current_feeSchedule: [
-    {
-      fees: [{servicedata: {gas: {low: 953000}}}],
-      hederaFunctionality: 84,
-    },
-    {
-      fees: [{servicedata: {gas: {low: 841000}}}],
-      hederaFunctionality: 6,
-    },
-    {
-      fees: [{servicedata: {gas: {low: 1000000}}}],
-      hederaFunctionality: 7,
-    },
-  ],
-  next_feeSchedule: [],
-};
-
-const expectedFeeScheduleLatestFile = {
-  timestamp: 4,
-  current_feeSchedule: [
-    {
-      fees: [{servicedata: {gas: {low: 853000}}}],
-      hederaFunctionality: 84,
-    },
-    {
-      fees: [{servicedata: {gas: {low: 741000}}}],
-      hederaFunctionality: 6,
-    },
-    {
-      fees: [{servicedata: {gas: {low: 990000}}}],
-      hederaFunctionality: 7,
-    },
-  ],
-  next_feeSchedule: [],
-};
-
-describe('FileDataService.getFeeSchedule', () => {
-  test('FileDataService.getFeeSchedule - No match', async () => {
-    await expect(FileDataService.getFeeSchedule({whereQuery: []})).resolves.toBeNull();
-  });
-
-  test('FileDataService.getFeeSchedule - Row match w latest', async () => {
-    await integrationDomainOps.loadFileData(feeScheduleFiles);
-    await expect(FileDataService.getFeeSchedule({whereQuery: []})).resolves.toMatchObject(
-      expectedFeeScheduleLatestFile
-    );
-  });
-
-  test('FileDataService.getFeeSchedule - Row match w previous latest', async () => {
-    await integrationDomainOps.loadFileData(feeScheduleFiles);
-
-    const where = [
-      {
-        query: `${FileData.CONSENSUS_TIMESTAMP} <= `,
-        param: expectedFeeSchedulePreviousFile.timestamp,
-      },
-    ];
-    await expect(FileDataService.getFeeSchedule({whereQuery: where})).resolves.toMatchObject(
-      expectedFeeSchedulePreviousFile
-    );
-  });
-});