refactor: static code analysis comments

Signed-off-by: Rob Walworth <[email protected]>

Author: rwalworth

Sources/Hiero/Client/Client.swift

@@ -256,8 +256,8 @@ public final class Client: Sendable {
         // Only take the plaintext nodes
         let filtered = NodeAddressBook(
             nodeAddresses: addressBook.nodeAddresses.map { address in
-                let plaintextEndpoints = address.serviceEndpoints.filter {
-                    $0.port == NodeConnection.consensusPlaintextPort
+                let plaintextEndpoints = address.serviceEndpoints.filter { endpoint in
+                    endpoint.port == NodeConnection.consensusPlaintextPort
                 }
 
                 return NodeAddress(

Sources/Hiero/Client/ConsensusNetwork.swift

@@ -160,8 +160,8 @@ internal final class ConsensusNetwork: Sendable, AtomicReference {
         for (index, address) in addressBook.enumerated() {
             // Use dictionary for O(1) port priority lookup instead of O(n) array search
             let endpoints = address.serviceEndpoints
-                .sorted {
-                    Self.portPriority[$0.port] ?? Int.max < Self.portPriority[$1.port] ?? Int.max
+                .sorted { endpoint1, endpoint2 in
+                    Self.portPriority[endpoint1.port] ?? Int.max < Self.portPriority[endpoint2.port] ?? Int.max
                 }
 
             let selected = endpoints.first.flatMap { endpoint -> HostAndPort? in

Sources/Hiero/Client/NetworkFactory.swift

@@ -39,7 +39,7 @@ internal enum NetworkFactory {
     ///   - realm: Realm number for custom networks (default: 0)
     /// - Returns: Configured consensus network
     /// - Throws: HError if network name is unknown or addresses are invalid
-    static func makeConsensusNetwork(
+    internal static func makeConsensusNetwork(
         spec: ConsensusNetworkSpecification,
         eventLoop: EventLoopGroup,
         shard: UInt64 = 0,
@@ -63,7 +63,7 @@ internal enum NetworkFactory {
     ///   - realm: Realm number for localhost (default: 0)
     /// - Returns: Configured consensus network
     /// - Throws: HError if network name is unknown
-    static func makeConsensusNetworkByName(
+    internal static func makeConsensusNetworkByName(
         _ name: borrowing String,
         eventLoop: EventLoopGroup,
         shard: UInt64 = 0,
@@ -102,7 +102,7 @@ internal enum NetworkFactory {
     ///   - eventLoop: Event loop group for managing connections
     /// - Returns: Configured mirror network, or empty mirror network if spec is nil
     /// - Throws: HError if network name is unknown
-    static func makeMirrorNetwork(
+    internal static func makeMirrorNetwork(
         spec: MirrorNetworkSpecification?,
         eventLoop: EventLoopGroup
     ) throws -> MirrorNetwork {
@@ -128,7 +128,7 @@ internal enum NetworkFactory {
     ///   - eventLoop: Event loop group for managing connections
     /// - Returns: Configured mirror network
     /// - Throws: HError if network name is unknown
-    static func makeMirrorNetworkByName(
+    internal static func makeMirrorNetworkByName(
         _ name: borrowing String,
         eventLoop: EventLoopGroup
     ) throws -> MirrorNetwork {
@@ -157,7 +157,7 @@ internal enum NetworkFactory {
     ///
     /// - Parameter name: Network name
     /// - Returns: Ledger ID for the network, or nil for custom/localhost networks
-    static func ledgerIdForNetworkName(_ name: borrowing String) -> LedgerId? {
+    internal static func ledgerIdForNetworkName(_ name: borrowing String) -> LedgerId? {
         switch name.lowercased() {
         case "mainnet":
             return .mainnet

Sources/Hiero/Client/NetworkSpecification.swift

@@ -33,7 +33,7 @@ internal enum NetworkSpecification<Custom: Decodable>: Decodable, Sendable where
     ///
     /// - Parameter decoder: The decoder to read data from
     /// - Throws: DecodingError if neither format can be decoded
-    init(from decoder: Decoder) throws {
+    internal init(from decoder: Decoder) throws {
         let container = try decoder.singleValueContainer()
 
         // Try decoding as string (network name) first