Skip to content

Conversation

@lmaertin
Copy link
Contributor

@lmaertin lmaertin commented Nov 6, 2025

Breaking change

Proposed change

Add chlorine and flow rate sensors to the Pooldose integration for extended device support.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Update snapshots for new sensors
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for chlorine-related sensors and a flow rate sensor with dynamic unit handling to the PoolDose integration. The changes expand the integration's sensor coverage to include chlorine monitoring and flow rate measurements.

Key changes:

  • Added three new sensors: chlorine level (cl), chlorine dosing type, and chlorine peristaltic dosing
  • Added flow rate sensor with dynamic unit support (similar to existing temperature sensor)
  • Added test coverage for flow rate sensor's dynamic unit behavior

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
homeassistant/components/pooldose/sensor.py Added sensor descriptions for cl, flow_rate, cl_type_dosing, and peristaltic_cl_dosing sensors; extended dynamic unit logic to support flow_rate
homeassistant/components/pooldose/strings.json Added translations for new chlorine and flow rate sensors with appropriate state mappings
homeassistant/components/pooldose/icons.json Added icon definitions for the new sensors
tests/components/pooldose/fixtures/instantvalues.json Added fixture data for cl_type_dosing and peristaltic_cl_dosing sensors
tests/components/pooldose/test_sensor.py Added test for flow rate sensor's dynamic unit behavior
tests/components/pooldose/snapshots/test_sensor.ambr Added snapshots for all new sensors including entity registry and state data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant