-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
Pooldose additional sensors #156002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Pooldose additional sensors #156002
Conversation
- Update icons, strings, and test fixtures - Maintain backward compatibility
Update snapshots for new sensors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for chlorine-related sensors and a flow rate sensor with dynamic unit handling to the PoolDose integration. The changes expand the integration's sensor coverage to include chlorine monitoring and flow rate measurements.
Key changes:
- Added three new sensors: chlorine level (cl), chlorine dosing type, and chlorine peristaltic dosing
- Added flow rate sensor with dynamic unit support (similar to existing temperature sensor)
- Added test coverage for flow rate sensor's dynamic unit behavior
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/pooldose/sensor.py |
Added sensor descriptions for cl, flow_rate, cl_type_dosing, and peristaltic_cl_dosing sensors; extended dynamic unit logic to support flow_rate |
homeassistant/components/pooldose/strings.json |
Added translations for new chlorine and flow rate sensors with appropriate state mappings |
homeassistant/components/pooldose/icons.json |
Added icon definitions for the new sensors |
tests/components/pooldose/fixtures/instantvalues.json |
Added fixture data for cl_type_dosing and peristaltic_cl_dosing sensors |
tests/components/pooldose/test_sensor.py |
Added test for flow rate sensor's dynamic unit behavior |
tests/components/pooldose/snapshots/test_sensor.ambr |
Added snapshots for all new sensors including entity registry and state data |
Co-authored-by: Copilot <[email protected]>
…rted by Home Assistant
Breaking change
Proposed change
Add chlorine and flow rate sensors to the Pooldose integration for extended device support.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: