chore: remove delivery event concept #653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename interface methods: InsertManyDeliveryEvent -> InsertMany, ListDeliveryEvent -> ListDelivery, RetrieveDeliveryEvent -> RetrieveDelivery - Rename request types: ListDeliveryEventRequest -> ListDeliveryRequest, etc. - Add DeliveryRecord type for query results with Event and Delivery - Update memlogstore, pglogstore, chlogstore implementations - Update all API handlers and tests to use new interface - Remove DeliveryEventID field from Delivery struct Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add DeliveryTask struct with IdempotencyKey() and RetryID() methods - Update deliverymq to publish/consume DeliveryTask instead of DeliveryEvent - Update publishmq to create and enqueue DeliveryTask - Update RetryTask to convert to DeliveryTask - Update API handlers, eventtracer, alert, emetrics to use DeliveryTask - Fix Delivery fields (TenantID, Attempt, Manual) not being set before logging - Add :manual suffix to idempotency key for manual retries Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update chlogstore/README.md method names and SQL examples - Update pglogstore/README.md method names - Update tracer_test.go comment to reference DeliveryTask Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Preserves Event-Delivery pairing through the insert flow, eliminating the need for eventMap reconstruction in ClickHouse implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove DeliveryEvent concept
This PR replaces the monolithic
DeliveryEventtype with purpose-specific types that better represent the different stages of event delivery.New Types
DeliveryTask- Message type for delivery processing queues. Flows frompublishmq→deliverymqand from retry →deliverymq. Contains theEvent,DestinationID,Attempt, andManualflag. ProvidesIdempotencyKey()for deduplication.RetryTask- Message type for scheduling retries. Contains only the metadata needed to re-fetch the event and re-attempt delivery (EventID,TenantID,DestinationID,Attempt). Converts toDeliveryTaskwhen the retry fires.LogEntry- Message type for the log queue. Contains bothEventandDeliveryfor persistence to the logstore.DeliveryRecord- Query result type returned by logstore. ContainsDeliverywith optionalEventpopulation for API responses.Logstore Interface Changes
InsertManyDeliveryEvent→InsertMany(events, deliveries)ListDeliveryEvent→ListDelivery(returnsDeliveryRecord)RetrieveDeliveryEvent→RetrieveDelivery(returnsDeliveryRecord)Other Changes
delivery_event_idcolumn from database schema/delivery-eventsAPI endpointsevent_id:destination_idformat (with:manualsuffix for manual retries)