await for FetchRequest delegate to handle response

Closes [#884]

Despite the fact that `Visit` and `FrameController` are `FetchRequest`
delegate classes that implement their delegate methods asynchronously on
success ([Visit.requestSucceededWithResponse][] and
[FrameController.requestSucceededWithResponse][]) and on failure
([Visit.requestFailedWithResponse][]) and
[FrameController.requestFailedWithResponse][]), the `async
FetchRequest.receive` method doesn't use the `await` keyword to wait for
those delegates to finish handling their callbacks.

This commit adds those `await` clauses.

[Visit.requestSucceededWithResponse]: https://github.com/hotwired/turbo/blob/c207f5b25758e4a084e8ae42e49712b91cf37114/src/core/drive/visit.js#L297
[FrameController.requestSucceededWithResponse]: https://github.com/hotwired/turbo/blob/c207f5b25758e4a084e8ae42e49712b91cf37114/src/core/frames/frame_controller.js#L210
[Visit.requestFailedWithResponse]: https://github.com/hotwired/turbo/blob/c207f5b25758e4a084e8ae42e49712b91cf37114/src/core/drive/visit.js#L311
[FrameController.requestFailedWithResponse]: https://github.com/hotwired/turbo/blob/c207f5b25758e4a084e8ae42e49712b91cf37114/src/core/frames/frame_controller.js#L215

[#884]: #884

Author: seanpdoyle

src/core/drive/form_submission.js

@@ -137,7 +137,7 @@ export class FormSubmission {
     this.result = { success: response.succeeded, fetchResponse: response }
   }
 
-  requestSucceededWithResponse(request, response) {
+  async requestSucceededWithResponse(request, response) {
     if (response.clientError || response.serverError) {
       this.delegate.formSubmissionFailedWithResponse(this, response)
       return
@@ -151,7 +151,7 @@ export class FormSubmission {
     } else {
       this.state = FormSubmissionState.receiving
       this.result = { success: true, fetchResponse: response }
-      this.delegate.formSubmissionSucceededWithResponse(this, response)
+      await this.delegate.formSubmissionSucceededWithResponse(this, response)
     }
   }
 

src/core/frames/frame_controller.js

@@ -233,11 +233,11 @@ export class FrameController {
     markAsBusy(formElement, this.#findFrameElement(formElement))
   }
 
-  formSubmissionSucceededWithResponse(formSubmission, response) {
+  async formSubmissionSucceededWithResponse(formSubmission, response) {
     const frame = this.#findFrameElement(formSubmission.formElement, formSubmission.submitter)
 
     frame.delegate.proposeVisitIfNavigatedWithAction(frame, getVisitAction(formSubmission.submitter, formSubmission.formElement, frame))
-    frame.delegate.loadResponse(response)
+    await frame.delegate.loadResponse(response)
 
     if (!formSubmission.isSafe) {
       session.clearCache()

src/http/fetch_request.js

@@ -155,7 +155,7 @@ export class FetchRequest {
     if (event.defaultPrevented) {
       this.delegate.requestPreventedHandlingResponse(this, fetchResponse)
     } else if (fetchResponse.succeeded) {
-      this.delegate.requestSucceededWithResponse(this, fetchResponse)
+      await this.delegate.requestSucceededWithResponse(this, fetchResponse)
     } else {
       this.delegate.requestFailedWithResponse(this, fetchResponse)
     }

src/tests/functional/form_submission_tests.js

@@ -647,11 +647,11 @@ test("frame POST form targeting frame submission", async ({ page }) => {
 
   await nextEventNamed(page, "turbo:before-fetch-response")
 
-  expect(await formSubmitEnded(page), "fires turbo:submit-end").toEqual("true")
-
   await nextEventNamed(page, "turbo:frame-render")
   await nextEventNamed(page, "turbo:frame-load")
 
+  await nextEventNamed(page, "turbo:submit-end")
+
   const otherEvents = await readEventLogs(page)
   expect(otherEvents.length, "no more events").toEqual(0)
 
@@ -698,11 +698,11 @@ test("frame GET form targeting frame submission", async ({ page }) => {
 
   await nextEventNamed(page, "turbo:before-fetch-response")
 
-  expect(await formSubmitEnded(page), "fires turbo:submit-end").toEqual("true")
-
   await nextEventNamed(page, "turbo:frame-render")
   await nextEventNamed(page, "turbo:frame-load")
 
+  await nextEventNamed(page, "turbo:submit-end")
+
   const otherEvents = await readEventLogs(page)
   expect(otherEvents.length, "no more events").toEqual(0)
 

src/tests/functional/frame_tests.js

@@ -719,9 +719,9 @@ test("navigating pushing URL state from a frame navigation fires events", async
   await nextEventOnTarget(page, "frame", "turbo:before-fetch-response")
   await nextEventOnTarget(page, "frame", "turbo:frame-render")
   await nextEventOnTarget(page, "frame", "turbo:frame-load")
-  expect(await nextAttributeMutationNamed(page, "frame", "aria-busy"), "removes aria-busy from the <turbo-frame>").not.toBeTruthy()
+  expect(await nextAttributeMutationNamed(page, "html", "aria-busy"), "true", "sets aria-busy on the <html>").toBeTruthy()
 
-  expect(await nextAttributeMutationNamed(page, "html", "aria-busy"), "sets aria-busy on the <html>").toEqual("true")
+  expect(await nextAttributeMutationNamed(page, "frame", "aria-busy"), "removes aria-busy from the <turbo-frame>").not.toBeTruthy()
   await nextEventOnTarget(page, "html", "turbo:before-visit")
   await nextEventOnTarget(page, "html", "turbo:visit")
   await nextEventOnTarget(page, "html", "turbo:before-cache")
@@ -933,8 +933,14 @@ test("navigating frame with form[method=post][data-turbo-action=advance] to the
   await page.click("#form-post-frame-action-advance button")
   await nextEventNamed(page, "turbo:load")
 
-  await expect(page.locator("#frame"), "clears turbo-frame[aria-busy]").not.toHaveAttribute("aria-busy")
-  await expect(page.locator("#html"), "clears html[aria-busy]").not.toHaveAttribute("aria-busy")
+  expect(await nextAttributeMutationNamed(page, "form-post-frame-action-advance", "aria-busy"), "sets aria-busy on the <form>").toEqual("true")
+  expect(await nextAttributeMutationNamed(page, "frame", "aria-busy"), "sets aria-busy on the <turbo-frame>").toEqual("true")
+  expect(await nextAttributeMutationNamed(page, "html", "aria-busy"), "sets aria-busy on the <html>").toEqual("true")
+
+  expect(await nextAttributeMutationNamed(page, "form-post-frame-action-advance", "aria-busy"), "removes aria-busy from the <form>").toEqual(null)
+  expect(await nextAttributeMutationNamed(page, "frame", "aria-busy"), "removes aria-busy from the <turbo-frame>").toEqual(null)
+  expect(await nextAttributeMutationNamed(page, "html", "aria-busy"), "removes aria-busy from the <html>").toEqual(null)
+
   await expect(page.locator("#html"), "clears html[data-turbo-preview]").not.toHaveAttribute("data-turbo-preview")
   await expect(page.locator("#frame"), "marks the frame as [complete]").toHaveAttribute("complete")
 })