play_url and yt_url related to #59 (#60)

* related to #49

* refactor(play): play_url

- documentation
- isort
- use boolean for yt_url's print_title
- type hint

* refactor(search): yt_url

- isort
- documentation
- only work on unique video id
- fix video title when printing
- print title when there is only video title
- use boolean for print_title parameter

* docs(pafy): extract_video_id

- isort
- documentation

Co-authored-by: Talha Asghar <[email protected]>

Co-authored-by: rachmadani haryono <[email protected]>

Author: iamtalhaasghar

mps_youtube/commands/play.py

@@ -1,12 +1,13 @@
+import random
 import sys
+import typing as T
 import webbrowser
-import random
 from urllib.error import HTTPError, URLError
 
-from .. import g, c, streams, util, content, config
-from . import command, WORD, RS
+from .. import c, config, content, g, streams, util
+from . import RS, WORD, command
+from .search import related, yt_url
 from .songlist import plist
-from .search import yt_url, related
 
 
 @command(r'play\s+(%s|\d+)' % WORD, 'play')
@@ -122,11 +123,20 @@ def play_all(pre, choice, post=""):
 
 
 @command(r'playurl\s(.*[-_a-zA-Z0-9]{11}[^\s]*)(\s-(?:f|a|w))?', 'playurl')
-def play_url(url, override):
-    """ Open and play a youtube video url. """
+def play_url(url: str, override: T.Any):
+    """Open and play a youtube video url.
+
+    Args:
+        url: url to be played
+        override: override
+
+    Raises:
+        SystemExit: If run from command line
+    """
+    # @fixme check override type hint
     override = override if override else "_"
     g.browse_mode = "normal"
-    yt_url(url, print_title=1)
+    yt_url(url, print_title=True)
 
     if len(g.model) == 1:
         play(override, "1", "_")

mps_youtube/commands/search.py

@@ -1,11 +1,14 @@
-import re
-import json
-import math
 import base64
+import json
 import logging
+import math
+import re
+import typing as T
+from argparse import ArgumentParser
 from datetime import datetime, timedelta
+from urllib import parse
+
 from .. import pafy
-from argparse import ArgumentParser
 
 parser = ArgumentParser()
 parser.add_argument('-d', '--duration', choices=('any', 'short', 'medium', 'long'))
@@ -15,11 +18,10 @@
 parser.add_argument('search', nargs='+')
 
 
-from .. import g, c, screen, config, util, content, listview, contentquery
-from ..playlist import Video, Playlist
+from .. import c, config, content, contentquery, g, listview, screen, util
+from ..playlist import Playlist, Video
 from . import command
-from .songlist import plist, paginatesongs
-
+from .songlist import paginatesongs, plist
 
 ISO8601_TIMEDUR_EX = re.compile(r'PT((\d{1,3})H)?((\d{1,3})M)?((\d{1,2})S)?')
 
@@ -552,17 +554,32 @@ def mix(num):
             g.message = util.F('no mix')
 
 
-@command(r'url\s(.*[-_a-zA-Z0-9]{11}.*)', 'url')
-def yt_url(url, print_title=0):
-    """ Acess videos by urls. """
+@command(r"url\s(.*[-_a-zA-Z0-9]{11}.*)", "url")
+def yt_url(url: str, print_title: bool = False):
+    """Acess videos by urls.
+
+    If `print_title` is true only last title from unique parsed id will be printed.
+
+    If for example `vid1` and `vid2` have title `title1` and `title2`, respectively,
+    `yt_url('vid1 vid2 vid1', True)`
+    will print `title2` from `vid2` instead `title1` from last entry `vid1`.
+
+    Args:
+        url: youtube url
+        print_title: print title or not
+    """
     url_list = url.split()
 
     g.model.songs = []
 
-    for u in url_list:
+    v_ids = set()
+    v_title = None
+    for url in url_list:
         try:
-            p = pafy.get_video_info(url.split('?v=')[1])#util.get_pafy(u)
-
+            v_id = pafy.extract_video_id(url)
+            if v_id in v_ids:
+                continue
+            p = pafy.get_video_info(v_id)
         except (IOError, ValueError) as e:
             g.message = c.r + str(e) + c.w
             g.content = g.content or content.generate_songlist_display(
@@ -571,13 +588,16 @@ def yt_url(url, print_title=0):
 
         g.browse_mode = "normal"
         v = Video(p['id'], p['title'], int(p['duration']['secondsText']))
+        if p and isinstance(p, dict):
+            v_title = p.get("title")
         g.model.songs.append(v)
+        v_ids.add(v_id)
 
     if not g.command_line:
         g.content = content.generate_songlist_display()
 
-    if print_title:
-        util.xprint(v.title)
+    if print_title and v_title:
+        util.xprint(v_title)
 
 
 @command(r'url_file\s(\S+)', 'url_file')

mps_youtube/pafy.py

@@ -1,6 +1,14 @@
-from youtubesearchpython import *
-import yt_dlp, random, os, requests, json, re
+import json
+import os
+import random
+import re
 from urllib.parse import parse_qs, urlparse
+
+import requests
+import yt_dlp
+from youtubesearchpython import *
+
+
 class MyLogger:
     def debug(self, msg):
         # For compatibility with youtube-dl, both debug and info are passed into debug
@@ -119,8 +127,27 @@ def get_video_info(video_id):
 def return_dislikes(video_id):
     return json.loads(requests.get('https://returnyoutubedislikeapi.com/votes?videoId=' + video_id).text)
 
-def extract_video_id(url):
-    """ Extract the video id from a url, return video id as str. """
+
+def extract_video_id(url: str) -> str:
+    """Extract the video id from a url, return video id as str.
+
+    Args:
+        url: url contain video id
+
+    Returns:
+        video id
+
+    Raises:
+        ValueError: If no video id found
+
+    Examples:
+
+        >>> extract_video_id('http://example.com')
+        >>> extract_video_id('https://www.youtube.com/watch?v=LDU_Txk06tM')
+        LDU_Txk06tM
+        >>> extract_video_id('https://youtu.be/LDU_Txk06tM')
+        LDU_Txk06tM
+    """
     idregx = re.compile(r'[\w-]{11}$')
     url = str(url).strip()
 
@@ -140,4 +167,4 @@ def extract_video_id(url):
             return vidid
 
     err = "Need 11 character video id or the URL of the video. Got %s"
-    raise ValueError(err % url)
+    raise ValueError(err % url)