Update according to code review

Author: taoliult

closed/test/jdk/openj9/internal/security/TestProperties.java

@@ -33,6 +33,7 @@
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
 
+import java.io.File;
 import java.security.Provider;
 import java.security.Security;
 
@@ -43,7 +44,7 @@
 
 public class TestProperties {
 
-    static String fileSep = java.io.File.pathSeparator;
+    static String fileSep = File.pathSeparator;
 
     private static Stream<Arguments> patternMatches_expectedExitValue0() {
         return Stream.of(
@@ -166,21 +167,31 @@ private static Stream<Arguments> patternMatches_expectedExitValue1() {
         );
     }
 
-    private static Stream<Arguments> patternMatches_PropertiesList() {
+    private static Stream<Arguments> patternMatches_propertiesList() {
         return Stream.of(
+                // "-Djava.security.propertiesList=" test 1: the profile in propertyListA-java.security
+                // extends the profile in the main java.security file, which lists 4 providers.
                 Arguments.of("Test-Profile-Property-List.A",
                         System.getProperty("test.src") + "/propertyListA-java.security",
                         "(?s)(?=.*OpenJCEPlusFIPS)(?=.*Sun)(?=.*SunJSSE)(?=.*SunEC)",
                         0),
+                // "-Djava.security.propertiesList=" test 2: The profile in propertyListB-java.security
+                // extends the profile in propertyListA-java.security, which in turn extends the profile
+                // in the main java.security file, listing 5 providers.
                 Arguments.of("Test-Profile-Property-List.B",
                         System.getProperty("test.src") + "/propertyListA-java.security" + fileSep
                                 + System.getProperty("test.src") + "/propertyListB-java.security",
                         "(?s)(?=.*OpenJCEPlusFIPS)(?=.*Sun)(?=.*SunJSSE)(?=.*SunEC)(?=.*SunJCE)",
                         0),
+                // "-Djava.security.propertiesList=" test 3: The profile in propertyListB-java.security
+                // extends the profile in propertyListA-java.security, which in turn extends the main
+                // java.security profile, but propertyListB-java.security file is missing.
                 Arguments.of("Test-Profile-Property-List.B",
                         System.getProperty("test.src") + "/propertyListB-java.security",
                         "is not present in the java.security file or any appended files",
                         1),
+                // "-Djava.security.propertiesList=" test 4: The -Djava.security.propertiesList option
+                // does not support using a leading '=' prefix.
                 Arguments.of("Test-Profile-Property-List.A",
                         "=" + System.getProperty("test.src") + "/propertyListA-java.security",
                         "java.security.propertiesList does not support '=' prefix",
@@ -215,8 +226,8 @@ public void shouldContain_expectedExitValue1(String customprofile, String securi
     }
 
     @ParameterizedTest
-    @MethodSource("patternMatches_PropertiesList")
-    public void shouldContain_PropertiesList(String customprofile, String securityPropertyFileList,
+    @MethodSource("patternMatches_propertiesList")
+    public void shouldContain_propertiesList(String customprofile, String securityPropertyFileList,
             String expected, int exitValue) throws Exception {
         OutputAnalyzer outputAnalyzer = ProcessTools.executeTestJava(
                 "-Dsemeru.fips=true",